DYN-9707 : Show warning when a file is opened in another Dynamo instance#17139
Conversation
draft - warning working
…-file-is-opened-in-another-Dynamo-instance
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9707
…ed-in-another-Dynamo-instance
|
We discussed in the check-in today the possibility of orphaned lock files. The logic still seems sound. We discussed the length of the timeout of 90 seconds being reasonable, which I think it is, but there is an edge case to consider. If the user has two instances of Dynamo open with a file open in one of them and Dynamo crashes, it is conceivable that the user could switch to the other instance and try to open the file, which now had an orphaned lock file, fairly quickly and well under the 90 seconds. It's probably a rare case, but it would be confusing if a user runs into it as the two options presented are to cancel opening the file and to create a copy of the file. It might merit some sort of text that explains this possibility? It might be overly verbose and almost never relevant though. @johnpierson , what do you think? |
jasonstratton
left a comment
There was a problem hiding this comment.
I had a couple of comments, but only one code change needed.
Great work! Thank you.
|
Thanks you @jasonstratton I pushed a follow-up PR here #17153. |
Thank you @ivaylo-matov . I did see the PR. Is it ready to review? ... I suppose I should ask there. 😄 |
|
I actually ran into the "orphaned dynlock" file myself when testing another issue that resulted in a hard crash. |



Purpose
This PR addresses DYN-9707:
The proposed logic adds a graph-file locking mechanism so Dynamo can detect when a
.dynor.dyffile is already open in another Dynamo instance and help avoid conflicting edits.Changes:
.dynlockfiles.DynamoModel.OpenFileFromPath.Declarations
Check these if you believe they are true
Release Notes
Dynamo now warns before opening a graph already open in another instance.
Reviewers
@DynamoDS/eidos
@jasonstratton
FYIs
@dnenov
@johnpierson