DYN-9663 fix missing parameter DataType in NodeDocumentationMarkdownGenerator#17141
Merged
jasonstratton merged 5 commits intoJun 12, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9663
johnpierson
force-pushed
the
DYN-9663-fix-missing-parameter-datatype
branch
from
4dd58cd to
e706161
Compare
Member
Author
|
Before/After |
RobertGlobant20
approved these changes
Jun 9, 2026
RobertGlobant20
left a comment
RobertGlobant20
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor comments
| /// <summary> | ||
| /// Collection of the nodes input port types. | ||
| /// </summary> | ||
| public IEnumerable<string> InputTypes { get; private set; } |
Contributor
There was a problem hiding this comment.
does it need to be added to the publid API?
jasonstratton
requested changes
Jun 10, 2026
jasonstratton
left a comment
jasonstratton
left a comment
Contributor
There was a problem hiding this comment.
Require adding methods to PublicAPI.Unshipped.txt
Adding a test for GetInputPoertType() default values is just suggested.
| /// <summary> | ||
| /// Collection of the nodes input port types. | ||
| /// </summary> | ||
| public IEnumerable<string> InputTypes { get; private set; } |
Contributor
There was a problem hiding this comment.
Yes. I think so. both InputTypes.get and OutputTypes.get are new public API
| } | ||
|
|
||
| // Fallback: infer from the port's default value node type. | ||
| return DefaultValue switch |
Contributor
There was a problem hiding this comment.
There are tests for GetInputPortType(). Please confirm that they cover the defaults for those cases when the NodeModel omits the InPortType
…enerator BuildParameters in AssemblyHandler.cs extracted only the parameter name from each VarDeclNode, ignoring arg.ArgumentType. Pass the ProtoCore.Type to TypedParameter so TypeName and TypeRank are populated in the generated node help data. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Output table had 3 column headers (Name, Description, DataType) but only emitted 2 <td> cells per row, leaving the DataType column always empty. Add the missing DataType cell using GetTypeFromDescription, consistent with the input port table rendering. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
GetTypeFromDescription parsed type from a multi-line tooltip string, which only worked when a parameter had a non-empty XML doc Summary. Nodes without Summary (common) or NodeModel nodes always showed empty type columns. Add InputTypes/OutputTypes to OpenNodeAnnotationEventArgs, populated via PortModel.GetInputPortType() and GetOutPortType() which correctly handle ZeroTouch, DesignScript, custom node, and NodeModel ([InPortTypes] attr) paths. Remove the now-unused GetTypeFromDescription helper. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…tribute NodeModel nodes without [InPortTypes] always returned null from GetInputPortType(), leaving the DataType column empty in the doc browser. As a fallback after the attribute check, infer the type string from the port's DefaultValue AST node: IntNode->int, DoubleNode->double, BooleanNode->bool, StringNode->string. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add the new OpenNodeAnnotationEventArgs input and output type properties to the WPF public API list. Cover the NodeModel input-port type fallback path for ports that omit InPortTypes but provide default value AST nodes.
johnpierson
force-pushed
the
DYN-9663-fix-missing-parameter-datatype
branch
from
b3fcfa9 to
1afece9
Compare
jasonstratton
approved these changes
Jun 12, 2026
jasonstratton
left a comment
jasonstratton
left a comment
Contributor
There was a problem hiding this comment.
Beat me to making the PublicAPI change. Thank you. ... Approved & will merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes missing DataType in the node documentation browser for input and output ports. Tracked in DYN-9663.
Three root causes addressed:
NodeDocumentationMarkdownGeneratordropped parameter types —BuildParametersinAssemblyHandler.csconstructedTypedParameterobjects with only the name, ignoringarg.ArgumentType. One-line fix to pass theProtoCore.Typethrough.Doc browser parsed type from a fragile multi-line string —
GetTypeFromDescriptiontried to extract type from a tooltip description string, which only worked when a parameter had a non-empty XML doc Summary. AddedInputTypes/OutputTypescollections toOpenNodeAnnotationEventArgs, populated directly fromPortModel.GetInputPortType()/GetOutPortType(), which already handle ZeroTouch, DesignScript, custom node, and[InPortTypes]/[OutPortTypes]attribute paths correctly.Output DataType cell was never emitted — Output table had 3 column headers (Name, Description, DataType) but only 2
<td>cells per row. Added the missing cell.NodeModel nodes without
[InPortTypes]always returned null — Added a fallback inGetInputPortType()to infer the type string from the port'sDefaultValueAST node (IntNode→int,DoubleNode→double,BooleanNode→bool,StringNode→string). NodeModel nodes without typed defaults or[InPortTypes]attributes will still show empty — those require separate annotation work.Declarations
Check these if you believe they are true
Release Notes
Fix missing DataType column in the node documentation browser. Input and output port types now display correctly for ZeroTouch, DesignScript, and NodeModel nodes. NodeModel nodes with typed default values (e.g.
Range,Sequence) will show inferred types even without explicit[InPortTypes]attributes.Reviewers
(FILL ME IN)
FYIs
(FILL ME IN, Optional)