DYN-10516 refresh templates and recent files from disk dynamically

src/DynamoCoreWpf/Controls/StartPage.xaml.cs

@@ -1,5 +1,6 @@
 using Dynamo.Configuration;
 using Dynamo.Logging;
+using Dynamo.UI.Prompts;
 using Dynamo.Utilities;
 using Dynamo.ViewModels;
 using Dynamo.Wpf.Properties;
@@ -16,6 +17,7 @@
 using System.Windows.Input;
 using System.Windows.Media;
 using System.Windows.Media.Imaging;
+using System.Threading.Tasks;
 using static Dynamo.Wpf.Interfaces.ResourceNames;
 using NotificationObject = Dynamo.Core.NotificationObject;
 
@@ -224,36 +226,34 @@ internal StartPageViewModel(DynamoViewModel dynamoViewModel, bool isFirstRun)
 
 
         private void LoadTemplates()
+        {
+            foreach (var templateItem in BuildTemplateListItems())
+            {
+                this.TemplateFiles.Add(templateItem);
+            }
+        }
+
+        private List<StartPageListItem> BuildTemplateListItems()
         {
             // Retrieve the current Temlates location from Dynamo properties
             var templatesDirectory = DynamoViewModel.Model.PathManager.TemplatesDirectory;
+            var templateItems = new List<StartPageListItem>();
 
             if (Directory.Exists(templatesDirectory))
             {
-                var rootDynPaths = new List<string>();
                 string[] filePaths = Directory.GetFiles(templatesDirectory, "*.dyn");   // This could change if we move to *dyt
 
-                // We only collect the files in the root
-                if (filePaths.Length != 0)
-                {
-                    foreach (string path in filePaths)
-                    {
-                        rootDynPaths.Add(path);
-                    }
-                }
-
                 // Make comment on legacy use of StartPage.xaml.cs
-                if (rootDynPaths.Any())
+                foreach (var filePath in filePaths)
                 {
-                    foreach (var filePath in rootDynPaths)
-                    {
-                        AddTemplateListItemFromPath(filePath);
-                    }
+                    templateItems.Add(CreateTemplateListItemFromPath(filePath));
                 }
             }
+
+            return templateItems;
         }
 
-        private void AddTemplateListItemFromPath(string filePath)
+        private StartPageListItem CreateTemplateListItemFromPath(string filePath)
         {
             var extension = Path.GetExtension(filePath).ToUpper();
             // If not extension specified and code reach here, this means this is still a valid file
@@ -276,7 +276,29 @@ private void AddTemplateListItemFromPath(string filePath)
                 ClickAction = StartPageListItem.Action.FilePath,
             };
 
-            this.TemplateFiles.Add(templateItem);
+            return templateItem;
+        }
+
+        internal void RefreshTemplateFiles()
+        {
+            TemplateFiles.Clear();
+            LoadTemplates();
+        }
+
+        internal async Task RefreshTemplateFilesAsync()
+        {
+            var templateItems = await Task.Run(BuildTemplateListItems);
+
+            TemplateFiles.Clear();
+            foreach (var templateItem in templateItems)
+            {
+                TemplateFiles.Add(templateItem);
+            }
+        }
+
+        internal void RefreshRecentFiles()
+        {
+            RefreshRecentFileList(DynamoViewModel.RecentFiles, true);
         }
 
         internal void WalkDirectoryTree(System.IO.DirectoryInfo root, SampleFileEntry rootProperty)
@@ -654,6 +676,11 @@ private void HandleRegularCommand(StartPageListItem item)
         private void HandleFilePath(StartPageListItem item)
         {
             var path = item.ContextData;
+            if (HandleMissingFilePath(path))
+            {
+                return;
+            }
+
             // Listed templates: use the same open path as the template file-picker (ShowOpenTemplateDialog),
             // i.e. open as a new graph from the file contents, not as the saved template path on disk.
             object openArg = IsTemplateFilePath(path)
@@ -671,6 +698,59 @@ private bool IsTemplateFilePath(string path)
                 string.Equals(template.ContextData, path, StringComparison.OrdinalIgnoreCase));
         }
 
+        internal bool HandleMissingFilePath(string path, bool showWarning = true)
+        {
+            if (File.Exists(path))
+            {
+                return false;
+            }
+
+            if (showWarning)
+            {
+                DynamoMessageBox.Show(
+                    DynamoViewModel.Owner,
+                    string.Format(Resources.MessageHomeFileMissing.Replace("\\n", Environment.NewLine), path),
+                    Resources.MessageErrorOpeningFileGeneral,
+                    MessageBoxButton.OK,
+                    MessageBoxImage.Warning);
+            }
+
+            RemoveMissingFilePath(path);
+
+            return true;
+        }
+
+        private void RemoveMissingFilePath(string path)
+        {
+            RemoveMissingFilePath(RecentFiles, path);
+            RemoveMissingFilePath(TemplateFiles, path);
+            RemoveMissingFilePath(DynamoViewModel.RecentFiles, path);
+        }
+
+        private static void RemoveMissingFilePath(ObservableCollection<StartPageListItem> files, string path)
+        {
+            var missingFiles = files
+                .Where(file => string.Equals(file.ContextData, path, StringComparison.OrdinalIgnoreCase))
+                .ToList();
+
+            foreach (var missingFile in missingFiles)
+            {
+                files.Remove(missingFile);
+            }
+        }
+
+        private static void RemoveMissingFilePath(ObservableCollection<string> files, string path)
+        {
+            var missingFiles = files
+                .Where(file => string.Equals(file, path, StringComparison.OrdinalIgnoreCase))
+                .ToList();
+
+            foreach (var missingFile in missingFiles)
+            {
+                files.Remove(missingFile);
+            }
+        }
+
         private void HandleExternalUrl(StartPageListItem item)
         {
             System.Diagnostics.Process.Start(new ProcessStartInfo(item.ContextData) { UseShellExecute = true });

src/DynamoCoreWpf/Properties/Resources.en-US.resx

@@ -4183,6 +4183,9 @@ To make this file into a new template, save it to a different folder, then move
   <data name="MessageErrorOpeningInvalidPath" xml:space="preserve">
     <value>Invalid file path provided. In case the file is archived, please make sure to extract it before opening.\n{0}</value>
   </data>
+  <data name="MessageHomeFileMissing" xml:space="preserve">
+    <value>This file is no longer available. It may have been moved, renamed, or deleted.\n{0}</value>
+  </data>
   <data name="GroupContextMenuFreezeGroup" xml:space="preserve">
     <value>Freeze Group</value>
   </data>

src/DynamoCoreWpf/Properties/Resources.resx

@@ -4174,6 +4174,9 @@ To make this file into a new template, save it to a different folder, then move
   <data name="MessageErrorOpeningInvalidPath" xml:space="preserve">
     <value>Invalid file path provided. In case the file is archived, please make sure to extract it before opening.\n{0}</value>
   </data>
+  <data name="MessageHomeFileMissing" xml:space="preserve">
+    <value>This file is no longer available. It may have been moved, renamed, or deleted.\n{0}</value>
+  </data>
   <data name="GroupContextMenuFreezeGroup" xml:space="preserve">
     <value>Freeze Group</value>
   </data>

src/DynamoCoreWpf/Views/HomePage/HomePage.xaml.cs

@@ -124,11 +124,28 @@ private void OnDataContextChanged(object sender, DependencyPropertyChangedEventA
             }
         }
 
-        private void DynamoViewModel_PropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
+        private async void DynamoViewModel_PropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
         {
             if(e.PropertyName == nameof(startPage.DynamoViewModel.ShowStartPage) && dynWebView?.CoreWebView2 != null)
             {
-                dynWebView.CoreWebView2.ExecuteScriptAsync(@$"window.setShowStartPageChanged('{startPage.DynamoViewModel.ShowStartPage}')");
+                try
+                {
+                    if (startPage.DynamoViewModel.ShowStartPage)
+                    {
+                        await startPage.RefreshTemplateFilesAsync();
+                        startPage.RefreshRecentFiles();
+
+                        await SendTemplateData();
+                        await SendRecentGraphsData();
+                    }
+
+                    await dynWebView.CoreWebView2.ExecuteScriptAsync(@$"window.setShowStartPageChanged('{startPage.DynamoViewModel.ShowStartPage}')");
+                }
+                catch (Exception ex)
+                {
+                    startPage?.DynamoViewModel?.Model?.Logger?.Log("Failed to update Dynamo Home visibility state.");
+                    startPage?.DynamoViewModel?.Model?.Logger?.Log(ex);
+                }
             }
         }
 
@@ -338,11 +355,8 @@ private async Task SendSamplesData()
         /// </summary>
         private async Task SendTemplateData()
         {
-            var items = startPage.TemplateFiles?.DistinctBy(x => x.ContextData).ToList();
-            if (items != null && items.Any())
-            {
-                await LoadTemplates(items);
-            }
+            var items = startPage.TemplateFiles?.DistinctBy(x => x.ContextData).ToList() ?? new List<StartPageListItem>();
+            await LoadTemplates(items);
         }
 
         private async Task SendRecentGraphsData()
@@ -361,14 +375,12 @@ private async Task SendRecentGraphsData()
             }
 
             // Load recent files
-            var recentFiles = startPage.RecentFiles?.DistinctBy(x => x.ContextData).ToList();
-            if (recentFiles != null && recentFiles.Any())
-            {
-                await LoadGraphs(recentFiles);
-            }
+            var recentFiles = startPage.RecentFiles?.DistinctBy(x => x.ContextData).ToList() ?? new List<StartPageListItem>();
+            await LoadGraphs(recentFiles);
 
             if (startPage.DynamoViewModel != null && startPage.DynamoViewModel.RecentFiles != null)
             {
+                startPage.DynamoViewModel.RecentFiles.CollectionChanged -= RecentFiles_CollectionChanged;
                 startPage.DynamoViewModel.RecentFiles.CollectionChanged += RecentFiles_CollectionChanged;
             }
         }
@@ -534,6 +546,11 @@ private void ShowPackagesGuidedTour()
 
         #region Relay Commands
         internal void OpenFile(string path)
+        {
+            _ = OpenFileAsync(path);
+        }
+
+        private async Task OpenFileAsync(string path)
         {
             if (String.IsNullOrEmpty(path)) return;
             if (DynamoModel.IsTestMode)
@@ -542,13 +559,31 @@ internal void OpenFile(string path)
                 return;
             }
 
-            var dvm = this.startPage.DynamoViewModel;
-            var openArg = IsListedHomePageTemplate(path)
-                ? (object)Tuple.Create(path, false, true)
-                : path;
-            if (dvm.OpenCommand.CanExecute(openArg))
+            try
+            {
+                if (startPage.HandleMissingFilePath(path))
+                {
+                    var recentFiles = startPage.RecentFiles?.DistinctBy(x => x.ContextData).ToList() ?? new List<StartPageListItem>();
+                    var templateFiles = startPage.TemplateFiles?.DistinctBy(x => x.ContextData).ToList() ?? new List<StartPageListItem>();
+
+                    await LoadGraphs(recentFiles);
+                    await LoadTemplates(templateFiles);
+                    return;
+                }
+
+                var dvm = this.startPage.DynamoViewModel;
+                var openArg = IsListedHomePageTemplate(path)
+                    ? (object)Tuple.Create(path, false, true)
+                    : path;
+                if (dvm.OpenCommand.CanExecute(openArg))
+                {
+                    dvm.OpenCommand.Execute(openArg);
+                }
+            }
+            catch (Exception ex)
             {
-                dvm.OpenCommand.Execute(openArg);
+                startPage?.DynamoViewModel?.Model?.Logger?.Log("Failed to open file from Dynamo Home.");
+                startPage?.DynamoViewModel?.Model?.Logger?.Log(ex);
             }
         }
 

test/DynamoCoreWpfTests/HomePageTests.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using Dynamo.Controls;
@@ -84,6 +85,31 @@ public void HomePage_NewSettingsAreAddedCorrectly()
             Assert.AreEqual(preferences.HomePageSettings.Count, 2);
         }
 
+        [Test]
+        public void HandleMissingFilePathRemovesPathFromAuthoritativeRecentFiles()
+        {
+            // Arrange
+            var missingPath = Path.Combine(Path.GetTempPath(), $"{Guid.NewGuid()}.dyn");
+            var vm = View.DataContext as DynamoViewModel;
+            var startPage = new StartPageViewModel(vm, true);
+            startPage.RecentFiles.Add(new StartPageListItem(missingPath) { ContextData = missingPath });
+            vm.RecentFiles.Add(missingPath);
+
+            Assert.IsFalse(File.Exists(missingPath));
+            Assert.IsTrue(vm.RecentFiles.Contains(missingPath));
+            Assert.IsTrue(vm.Model.PreferenceSettings.RecentFiles.Contains(missingPath));
+
+            // Act
+            var wasMissing = startPage.HandleMissingFilePath(missingPath, false);
+
+            // Assert
+            Assert.IsTrue(wasMissing);
+            Assert.IsFalse(startPage.RecentFiles.Any(file =>
+                string.Equals(file.ContextData, missingPath, StringComparison.OrdinalIgnoreCase)));
+            Assert.IsFalse(vm.RecentFiles.Contains(missingPath));
+            Assert.IsFalse(vm.Model.PreferenceSettings.RecentFiles.Contains(missingPath));
+        }
+
         #endregion
 
         #region integration tests