Skip to content

DYN-8957 fix: set NoNetworkMode before InitializeComponent in WorkspaceDependencyView #17170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonstratton wants to merge 1 commit into from
Closed

DYN-8957 fix: set NoNetworkMode before InitializeComponent in WorkspaceDependencyView #17170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/WorkspaceDependencyViewExtension/WorkspaceDependencyView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ internal void ForceTriggerDependencyRegen()
/// <param name="p">ViewLoadedParams</param>
public WorkspaceDependencyView(WorkspaceDependencyViewExtension viewExtension, ViewLoadedParams p)
{
// NoNetworkMode must be set before InitializeComponent so the XAML DataTrigger
// that disables the Install button reads the correct value on first evaluation.
// A plain CLR property has no change notification, so the trigger only fires once.
NoNetworkMode = p.StartupParams.NoNetworkMode;
InitializeComponent();
this.DataContext = this;
currentWorkspace = p.CurrentWorkspaceModel as WorkspaceModel;
Expand All @@ -156,7 +160,6 @@ public WorkspaceDependencyView(WorkspaceDependencyViewExtension viewExtension, V
currentWorkspace.PropertyChanged += OnWorkspacePropertyChanged;
loadedParams = p;
packageInstaller = p.PackageInstaller;
NoNetworkMode = p.StartupParams.NoNetworkMode;
dependencyViewExtension = viewExtension;
HomeWorkspaceModel.WorkspaceClosed += this.CloseExtensionTab;
}
Expand Down
Loading