DYN-8957 refactor: rename test to match its actual assertion#17171
Closed
jasonstratton wants to merge 1 commit into
Closed
DYN-8957 refactor: rename test to match its actual assertion#17171jasonstratton wants to merge 1 commit into
jasonstratton wants to merge 1 commit into
Conversation
WhenNoNetworkModeThenWorkspaceReferencesInstallButtonIsDisabled implied a UI-level assertion on Button.IsEnabled, but the test only verified that the NoNetworkMode property propagates from StartupParams into the DependencyView. Rename to WhenNoNetworkModeThenDependencyViewNoNetworkModeIsTrue to keep the suite self-describing. The UI-level assertion belongs in AGT tests. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8957
|
Contributor
Author
|
Changes applied directly to PR #17149 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WhenNoNetworkModeThenWorkspaceReferencesInstallButtonIsDisabledimplies a UI-level assertion onButton.IsEnabled, but the test only verifies thatDependencyView.NoNetworkModeis propagated fromStartupParams.WhenNoNetworkModeThenDependencyViewNoNetworkModeIsTrueso the test name accurately describes what it asserts.Test plan
WhenNoNetworkModeThenDependencyViewNoNetworkModeIsTruepasses🤖 Generated with Claude Code