DYN-10640: Port context menu flashes for a split second then disappears

[ivaylo-matov]

Purpose

This PR fixes DYN-10639, a regression introduced in #16763 where the port context menu briefly flashes and then disappears when opened with a left mouse click.

This PR makes WorkspaceView subscribe to its owner window's Deactivated event and close the port context menu when Dynamo loses focus:

• WorkspaceView_Loaded / WorkspaceView_Unloaded - resolve the owner window via Window.GetWindow(this) and subscribe/unsubscribe the Deactivated handler. The cached ownerWindow field guarantees we unsubscribe from the exact same window in Unloaded/Dispose.
• OwnerWindow_Deactivated - closes the port context menu via DestroyPortContextMenu() on window deactivation.

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

Port context menu does not flash only for a split second when called with left mouse click and closed when the owner window loses focus.

Reviewers

@DynamoDS/eidos
@jasonstratton
@johnpierson

FYIs

@dnenov

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10640

[ivaylo-matov]

I can see that Smoke Test and SelfServe are failing, but I can't see the details. Can I please get access or a list of the failing tests? Thanks 😊

[jasonstratton]

Added a small cleanup in Dispose() (commit 4667364): unsubscribe from ownerWindow.Deactivated and null the field there, so we're covered if Dispose() is ever called before the Unloaded event fires. Without it, the WorkspaceView could stay rooted via the handler on the owner Window. Verified the new test still passes locally.

[jasonstratton]

Needed a simple additional cleanup in WorkspaceView.dispose() method. I just added it myself.

Looks good. Approved and merging

[jasonstratton]

Missing one bit of cleanup, unsubscribing to OwnerWindow_Deactivated.

Simple change. I'll add it and merge.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud