Skip to content

10450: Revert "DYN-10553: Consume DynamoMCP NuGet as a built-in package (#17…#17188

Merged
jasonstratton merged 1 commit into
masterfrom
DYN-10450-RevertChanges-CheckBuildScripts
Jun 23, 2026
Merged

10450: Revert "DYN-10553: Consume DynamoMCP NuGet as a built-in package (#17…#17188
jasonstratton merged 1 commit into
masterfrom
DYN-10450-RevertChanges-CheckBuildScripts

Conversation

@RobertGlobant20

Copy link
Copy Markdown
Contributor

Purpose

This reverts commit 0cb9686. #17165
This is just to check if this change generated a problem in the DynamoBuildscripts job

Declarations

Check these if you believe they are true

Release Notes

This is just to check if this change generated a problem in the DynamoBuildscripts job

Reviewers

@jasonstratton

FYIs

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10450

@github-actions github-actions Bot changed the title Revert "DYN-10553: Consume DynamoMCP NuGet as a built-in package (#17… 10450: Revert "DYN-10553: Consume DynamoMCP NuGet as a built-in package (#17… Jun 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the prior change that consumed the DynamoVisualProgramming.DynamoMCP NuGet as a built-in package, in order to validate whether that integration was the cause of issues in the DynamoBuildscripts job.

Changes:

  • Removes the DynamoMCP NuGet PackageReference and the MSBuild target that copied it into Built-In Packages\packages\DynamoMCP.
  • Updates WPF package manager tests to reflect the removal of the MCP built-in package / view extension.
  • Removes DynamoMCP-related binary exclusions from the CI file-version checking script.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/DynamoCoreWpf2Tests/PackageManager/PackageManagerViewExtensionTests.cs Adjusts expected requested view-extension counts after removing MCP.
test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs Updates expected built-in package count to match reverted packaging behavior.
test/DynamoCoreWpf2Tests/PackageManager/PackageManagerExtensionLoadingTests.cs Removes “Dynamo MCP View Extension” from the expected loaded view extensions list.
src/DynamoCoreWpf/DynamoCoreWpf.csproj Removes DynamoMCP NuGet consumption and copy-to-built-in-packages build target.
.github/scripts/check_file_version.ps1 Removes DynamoMCP-related DLL name exclusions now that those binaries should no longer be produced.

@jasonstratton jasonstratton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving and merging

@jasonstratton jasonstratton merged commit c835a88 into master Jun 23, 2026
33 of 34 checks passed
@jasonstratton jasonstratton deleted the DYN-10450-RevertChanges-CheckBuildScripts branch June 23, 2026 00:04
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants