Add NET_OSX (osx-arm64) build target for DynamoCLI - #17253
Open
saintentropy wants to merge 1 commit into
Open
Conversation
Mirror the NET_Linux target so DynamoCLI and the cross-platform core build and run on macOS / Apple Silicon: - Config/CS_SDK.props: NET_OSX + Publish_OSX platforms, osx-arm64 RID, _OSX define, AnyCPU PlatformTarget, portable pdbs for OSX - DynamoCore.sln: NET_OSX + Publish_OSX solution and per-project configurations - DynamoCore.csproj: osx-arm64 LibGOsToken so the mac LibG payload is consumed - StartupUtils.cs: macOS ASM search pattern (*ASMahl*.dylib) in PreloadASM Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new macOS (Apple Silicon) build target (NET_OSX / Publish_OSX, osx-arm64) to align DynamoCore/DynamoCLI’s cross-platform build configuration with the existing Linux target, including OS-specific geometry/ASM loading behavior.
Changes:
- Adds
NET_OSX/Publish_OSXplatforms/configurations to the shared SDK props andDynamoCore.sln. - Updates
DynamoCore.csprojto select an OS X-specificLibGOsTokenfor pulling LibG assets. - Extends ASM binary discovery in
StartupUtils.PreloadASMto handle.dylibon macOS.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/DynamoCore/DynamoCore.csproj | Adds LibGOsToken selection for OSX builds to locate OS X LibG assets. |
| src/DynamoCore.sln | Adds NET_OSX / Publish_OSX solution configurations and project mappings. |
| src/DynamoApplications/StartupUtils.cs | Uses a macOS .dylib search pattern when extracting ASM version for LibG preload. |
| src/Config/CS_SDK.props | Defines NET_OSX / Publish_OSX platforms, sets osx-arm64 RID, _OSX constant, and portable PDB settings. |
| throw new FileNotFoundException($"{nameof(asmPath)}:{asmPath}"); | ||
| } | ||
| Version asmBinariesVersion = DynamoShapeManager.Utilities.GetVersionFromPath(asmPath, OSHelper.IsWindows() ? "*ASMAHL*.dll" : "*ASMahl*.so"); | ||
| Version asmBinariesVersion = DynamoShapeManager.Utilities.GetVersionFromPath(asmPath, OSHelper.IsWindows() ? "*ASMAHL*.dll" : OperatingSystem.IsMacOS() ? "*ASMahl*.dylib" : "*ASMahl*.so"); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
WIP / draft — do not review yet. Jira ticket (DYN-####) and full PR template to be completed later.
Adds a NET_OSX (osx-arm64 / Apple Silicon) build target mirroring NET_Linux so DynamoCLI and the cross-platform core build and run on macOS.
Verified on Apple Silicon: DynamoCLI evaluates a geometry graph end-to-end via the arm64 LibG + ASM kernel. Pairs with the companion LibG osx-arm64 PR.
Declarations
Check these if you believe they are true
Release Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of