Elementtype nodes - #2486
Merged
Merged
Conversation
* Element.GetSubComponents (#16) * Element.GetSubComponents node with icons * Element.GetSubComponents tests * ElementTypeByName node * ElementTypeByName tests * Created ElemetType class * made types inherit from ElementType * node images + small fixes * element and wall type tests * Update WallTypeTests.cs * ElementType tests * WallType, FloorType and RoofType tests * Revert sample DYN files This reverts commit 38bd219. * comment updates * change var to int
ZiyunShang
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR fixes the build failure on the previous pr #2468
Purpose
This PR introduces an ElementType category to the Dynamo library, all other Dynamo types (WallType, FloorType, etc.) now inherits from ElementType which means a lot of duplicated code has been removed.
The following new nodes have been added:
ElementType nodes
WallType nodes
FloorType nodes
RoofType nodes
All of the nodes have related unit and system tests, which has been run in RTF before submitting.
Unit Test
System Test
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@AndyDu1985
@radumg
@mjkkirschner
@ZiyunShang
FYIs
Screenshots of the dynamo graphs for the system test
ElementType Properties test
ElementType by name test
Duplicate ElementType test
ElementType get preview image test
WallType Properties test
WallType Thermal Properties test
Check if FloorType is foundation slab test
get FloorType structural material test
FloorType thermal properties test
RoofType thermal properties test