first draft of updating D4R to .NET 10#3219
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates DynamoRevit to support .NET 10 by adding build configurations and updating dependency versions. The changes prepare the codebase for migration from .NET 8.0 to .NET 10.0 while maintaining backward compatibility.
- Adds NET100 platform configurations alongside existing NET80 configurations
- Updates Dynamo core package references from version 3.6.1.9895 to 4.0.0-beta2630
- Modifies build scripts to use dynamic library subfolder references
Reviewed Changes
Copilot reviewed 5 out of 893 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoRevit/DynamoRevit.csproj | Updates copy targets to use dynamic library path variables |
| src/DynamoRevit.All.sln | Adds NET100 Debug and Release configurations for all projects |
| src/Config/packages_versions.props | Updates DYNAMOCORE_VERSION to 4.0.0-beta2630 |
| src/Config/packages.aget | Updates all Dynamo package references to 4.0.0-beta2630 |
| src/Config/CS_SDK.props | Adds NET100 platform support with net10.0-windows target framework |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <TargetFramework Condition="'$(Platform)' == 'NET80'">net8.0-windows</TargetFramework> | ||
| <TargetFramework Condition="'$(Platform)' == 'NET100'">net10.0-windows</TargetFramework> | ||
| <DCoreLibSubFolder Condition="'$(Platform)' == 'NET80'">net8.0</DCoreLibSubFolder> | ||
| <DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net8.0</DCoreLibSubFolder> |
There was a problem hiding this comment.
The DCoreLibSubFolder for NET100 platform should be 'net10.0' not 'net8.0' to match the target framework being used for .NET 10.
Suggested change
| <DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net8.0</DCoreLibSubFolder> | |
| <DCoreLibSubFolder Condition="'$(Platform)' == 'NET100'">net10.0</DCoreLibSubFolder> |
* update GregRevitAuth * move some dependencies from aget to nuget method
Mikhinja
marked this pull request as ready for review
October 2, 2025 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevitrepo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTMlabel is added to the PR.Purpose
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of