Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -225,3 +225,5 @@ test/SystemInJson

# Icon resources
/src/DynamoRevitIcons/*.resources

logs/*
6 changes: 6 additions & 0 deletions global.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"sdk": {
"version": "10.0.100",
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says "Added global.json with SDK 10.0.0", but the actual pinned SDK is "10.0.100". Please align the PR description (or the file) so the expected toolchain is unambiguous.

Copilot uses AI. Check for mistakes.
"rollForward": "minor"
}
}
2 changes: 1 addition & 1 deletion src/AssemblySharedInfoGenerator/AssemblySharedInfo.tt
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,6 @@ using System.Runtime.InteropServices;
<#+
int MajorVersion = 3;
int MinorVersion = 3;
int BuildNumber = 0;
int BuildNumber = 2;
int RevisionNumber = ((int)(DateTime.UtcNow - new DateTime(2023,1,1)).TotalDays)*10+((int)DateTime.UtcNow.Hour)/3;
#>
19 changes: 7 additions & 12 deletions src/Config/CS_SDK.props
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
<Project>
<Import Project="$(SolutionDir)Config/user_local.props" />
<PropertyGroup>
<Platforms>NET70;NET80</Platforms>
<Platforms>NET100</Platforms>
<PlatformTarget >x64</PlatformTarget>
<TargetFramework Condition="'$(Platform)' == 'NET80'">net8.0-windows</TargetFramework>
<TargetFramework Condition="'$(Platform)' == 'NET70'">net7.0-windows</TargetFramework>
<TargetFramework Condition="'$(Platform)' == 'NET60'">net6.0-windows</TargetFramework>
<TargetFramework Condition="'$(Platform)' == 'net48'">net48</TargetFramework>
<TargetFramework Condition="'$(Platform)' == 'NET100'">net10.0-windows</TargetFramework>
<DCoreLibSubFolder>net10.0</DCoreLibSubFolder>
Comment on lines +6 to +7
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR notes say DCoreLibSubFolder should remain net8.0 for NET100 until the DynamoVisualProgramming packages are published for .NET 10, but the props file now unconditionally sets it to net10.0. This mismatch is likely to break local builds that rely on lib\Revit {version}\{subfolder}. Consider setting DCoreLibSubFolder to net8.0 for NET100 (temporarily), or making it conditional/overridable via the imported version props so the build can continue using net8 assets while targeting net10.

Copilot uses AI. Check for mistakes.
<VisualStudioVersion Condition="'$(VisualStudioVersion)' == ''">17.0</VisualStudioVersion>
<RevitVersionNumber Condition=" '$(RevitVersionNumber)' == '' ">2025</RevitVersionNumber>
<REVIT_VERSION>Revit_$(RevitVersionNumber)</REVIT_VERSION>
Expand All @@ -20,22 +18,19 @@

<DYNAMOTESTAPI Condition=" '$(DYNAMOTESTAPI)' == '' ">C:\Program Files\Dynamo 0.7</DYNAMOTESTAPI>

<DCoreLibSubFolder Condition="'$(Platform)' == 'NET80'">net8.0</DCoreLibSubFolder>
<DCoreLibSubFolder Condition="'$(Platform)' == 'NET70'">net6.0</DCoreLibSubFolder>
<DCoreLibSubFolder Condition="'$(Platform)' == 'NET60'">net6.0</DCoreLibSubFolder>
<REVITAPI Condition=" !Exists('$(REVITAPI)') ">$(SolutionDir)..\lib\Revit $(RevitVersionNumber)\$(DCoreLibSubFolder)</REVITAPI>
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR notes say DCoreLibSubFolder should remain net8.0 for NET100 until the DynamoVisualProgramming packages are published for .NET 10, but the props file now unconditionally sets it to net10.0. This mismatch is likely to break local builds that rely on lib\Revit {version}\{subfolder}. Consider setting DCoreLibSubFolder to net8.0 for NET100 (temporarily), or making it conditional/overridable via the imported version props so the build can continue using net8 assets while targeting net10.

Copilot uses AI. Check for mistakes.
<REVITAPI Condition=" !Exists('$(REVITAPI)') ">C:\Program Files\Autodesk\Revit Architecture $(RevitVersionNumber)</REVITAPI>
<REVITAPI Condition=" !Exists('$(REVITAPI)') ">C:\Program Files\Autodesk\Revit $(RevitVersionNumber)</REVITAPI>
<REVITAPI Condition=" !Exists('$(REVITAPI)') ">C:\Program Files\Autodesk\Revit Preview Release</REVITAPI>
<REVITAPI Condition=" !Exists('$(REVITAPI)') ">C:\Program Files\Autodesk\Revit 2025</REVITAPI>
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final fallback hard-codes "Revit 2025", which is redundant when RevitVersionNumber is 2025 (it duplicates line 23) and inconsistent when RevitVersionNumber changes (it won’t track the selected version). Consider removing this hard-coded path, or parameterizing it in a way that matches the earlier fallbacks.

Suggested change
<REVITAPI Condition=" !Exists('$(REVITAPI)') ">C:\Program Files\Autodesk\Revit 2025</REVITAPI>

Copilot uses AI. Check for mistakes.

<BaseIntermediateOutputPath>$(SolutionDir)..\obj\$(Configuration)\$(Platform)\$(MSBuildProjectName)\</BaseIntermediateOutputPath>
<IntermediateOutputPath>$(BaseIntermediateOutputPath)</IntermediateOutputPath>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<DefaultOutputPath>$(SolutionDir)..\bin\$(Configuration)\$(Platform)\$(REVIT_VERSION)</DefaultOutputPath>
<DefaultOutputPath>$(SolutionDir)..\bin\$(Platform)\$(Configuration)\Revit</DefaultOutputPath>
<OutputPath Condition=" '$(OutputPath)' == '' ">$(DefaultOutputPath)</OutputPath>
<TestOutputPath Condition=" '$(TestOutputPath)' == '' ">$(SolutionDir)..\bin\$(Configuration)\$(Platform)\$(REVIT_VERSION)</TestOutputPath>
<TestOutputPath Condition=" '$(TestOutputPath)' == '' ">$(SolutionDir)..\bin\$(Platform)\$(Configuration)\Revit</TestOutputPath>

<NoWarn>MSB3539</NoWarn>
<NoWarn>MSB3539;CS3001;CS3002;CS3003;CS3009;CS3016;CS3027</NoWarn>
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds broad suppression of multiple CS30xx warnings (typically CLS compliance-related). If these are intentional, consider documenting why (e.g., with an XML comment near the property), or scoping the suppression to the specific projects that generate the warnings (instead of the shared SDK props) to avoid hiding new warnings introduced later.

Suggested change
<NoWarn>MSB3539;CS3001;CS3002;CS3003;CS3009;CS3016;CS3027</NoWarn>
<!-- Keep shared warning suppression narrowly scoped; add any CLS-related CS30xx suppressions in the specific project file that requires them. -->
<NoWarn>MSB3539</NoWarn>

Copilot uses AI. Check for mistakes.
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
<DebugSymbols>true</DebugSymbols>
Expand Down
17 changes: 8 additions & 9 deletions src/Config/packages.aget
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@
"nuget": {
"references": {
"DynamicLanguageRuntime": "1.2.2",
"DynamoVisualProgramming.Core": "3.3.1.7726",
"DynamoVisualProgramming.DynamoCoreNodes": "3.3.1.7726",
"DynamoVisualProgramming.DynamoServices": "3.3.1.7726",
"DynamoVisualProgramming.Tests": "3.3.1.7726",
"DynamoVisualProgramming.WpfUILibrary": "3.3.1.7726",
"DynamoVisualProgramming.ZeroTouchLibrary": "3.3.1.7726",
"DynamoVisualProgramming.DynamoSamples": "3.3.1.7726",
"DynamoVisualProgramming.Core": "3.3.2.11986",
"DynamoVisualProgramming.DynamoCoreNodes": "3.3.2.11986",
"DynamoVisualProgramming.DynamoServices": "3.3.2.11986",
"DynamoVisualProgramming.Tests": "3.3.2.11986",
"DynamoVisualProgramming.WpfUILibrary": "3.3.2.11986",
"DynamoVisualProgramming.ZeroTouchLibrary": "3.3.2.11986",
"DynamoVisualProgramming.DynamoSamples": "3.3.2.11986",
Comment on lines +5 to +11
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR notes explicitly say the DynamoVisualProgramming.* packages “are not updated”, but this change bumps them from 3.3.1.7726 to 3.3.2.11986. Please update the Notes section to reflect the actual change, or revert these package bumps if the intent is truly to keep them unchanged for now.

Copilot uses AI. Check for mistakes.
"Greg": "3.0.1.4707",
"GregRevitAuth": "3.0.8935.26399",
"pythonnet_py38_win": "2.5.1",
"Newtonsoft.Json": "13.0.1",
"NUnit": "3.13.3",
"Prism": "4.1.0",
"RestSharp": "112.0.0",
"System.Resources.Extensions": "5.0.0"
"RestSharp": "112.0.0"
}
}
}
109 changes: 55 additions & 54 deletions src/DynamoRevit.All.sln
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
ProjectSection(SolutionItems) = preProject
..\.version = ..\.version
..\CHANGELOG.md = ..\CHANGELOG.md
..\global.json = ..\global.json
..\README.md = ..\README.md
EndProjectSection
EndProject
Expand All @@ -78,62 +79,62 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "config", "config", "{956846
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|NET80 = Debug|NET80
Release|NET80 = Release|NET80
Debug|NET100 = Debug|NET100
Release|NET100 = Release|NET100
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Debug|NET80.ActiveCfg = Debug|NET80
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Debug|NET80.Build.0 = Debug|NET80
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Release|NET80.ActiveCfg = Release|NET80
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Release|NET80.Build.0 = Release|NET80
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Debug|NET80.ActiveCfg = Debug|NET80
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Debug|NET80.Build.0 = Debug|NET80
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Release|NET80.ActiveCfg = Release|NET80
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Release|NET80.Build.0 = Release|NET80
{75940ACC-3708-4526-8D91-7E3365BAF682}.Debug|NET80.ActiveCfg = Debug|NET80
{75940ACC-3708-4526-8D91-7E3365BAF682}.Debug|NET80.Build.0 = Debug|NET80
{75940ACC-3708-4526-8D91-7E3365BAF682}.Release|NET80.ActiveCfg = Release|NET80
{75940ACC-3708-4526-8D91-7E3365BAF682}.Release|NET80.Build.0 = Release|NET80
{E4701F9E-41AB-4044-8166-85D924FEB632}.Debug|NET80.ActiveCfg = Debug|NET80
{E4701F9E-41AB-4044-8166-85D924FEB632}.Debug|NET80.Build.0 = Debug|NET80
{E4701F9E-41AB-4044-8166-85D924FEB632}.Release|NET80.ActiveCfg = Release|NET80
{E4701F9E-41AB-4044-8166-85D924FEB632}.Release|NET80.Build.0 = Release|NET80
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Debug|NET80.ActiveCfg = Debug|NET80
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Debug|NET80.Build.0 = Debug|NET80
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Release|NET80.ActiveCfg = Release|NET80
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Release|NET80.Build.0 = Release|NET80
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Debug|NET80.ActiveCfg = Debug|NET80
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Debug|NET80.Build.0 = Debug|NET80
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Release|NET80.ActiveCfg = Release|NET80
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Release|NET80.Build.0 = Release|NET80
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Debug|NET80.ActiveCfg = Debug|NET80
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Debug|NET80.Build.0 = Debug|NET80
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Release|NET80.ActiveCfg = Release|NET80
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Release|NET80.Build.0 = Release|NET80
{53D05530-CF64-4883-8F86-B2B819934F83}.Debug|NET80.ActiveCfg = Debug|NET80
{53D05530-CF64-4883-8F86-B2B819934F83}.Debug|NET80.Build.0 = Debug|NET80
{53D05530-CF64-4883-8F86-B2B819934F83}.Release|NET80.ActiveCfg = Release|NET80
{53D05530-CF64-4883-8F86-B2B819934F83}.Release|NET80.Build.0 = Release|NET80
{589F14D7-2937-479C-834A-D44197CB1930}.Debug|NET80.ActiveCfg = Debug|NET80
{589F14D7-2937-479C-834A-D44197CB1930}.Debug|NET80.Build.0 = Debug|NET80
{589F14D7-2937-479C-834A-D44197CB1930}.Release|NET80.ActiveCfg = Release|NET80
{589F14D7-2937-479C-834A-D44197CB1930}.Release|NET80.Build.0 = Release|NET80
{133FC760-5699-46D9-BEA6-E816B5F01016}.Debug|NET80.ActiveCfg = Debug|NET80
{133FC760-5699-46D9-BEA6-E816B5F01016}.Debug|NET80.Build.0 = Debug|NET80
{133FC760-5699-46D9-BEA6-E816B5F01016}.Release|NET80.ActiveCfg = Release|NET80
{133FC760-5699-46D9-BEA6-E816B5F01016}.Release|NET80.Build.0 = Release|NET80
{9ADADC68-36A3-4A21-9B54-298154A88720}.Debug|NET80.ActiveCfg = Debug|NET80
{9ADADC68-36A3-4A21-9B54-298154A88720}.Debug|NET80.Build.0 = Debug|NET80
{9ADADC68-36A3-4A21-9B54-298154A88720}.Release|NET80.ActiveCfg = Release|NET80
{9ADADC68-36A3-4A21-9B54-298154A88720}.Release|NET80.Build.0 = Release|NET80
{A31E274C-524A-40CA-85FF-595D3DB53777}.Debug|NET80.ActiveCfg = Debug|NET80
{A31E274C-524A-40CA-85FF-595D3DB53777}.Debug|NET80.Build.0 = Debug|NET80
{A31E274C-524A-40CA-85FF-595D3DB53777}.Release|NET80.ActiveCfg = Release|NET80
{A31E274C-524A-40CA-85FF-595D3DB53777}.Release|NET80.Build.0 = Release|NET80
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Debug|NET80.ActiveCfg = Debug|NET80
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Debug|NET80.Build.0 = Debug|NET80
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Release|NET80.ActiveCfg = Release|NET80
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Release|NET80.Build.0 = Release|NET80
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Debug|NET100.ActiveCfg = Debug|NET100
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Debug|NET100.Build.0 = Debug|NET100
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Release|NET100.ActiveCfg = Release|NET100
{FD56AE51-739E-4893-8DE4-925D60C7097C}.Release|NET100.Build.0 = Release|NET100
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Debug|NET100.ActiveCfg = Debug|NET100
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Debug|NET100.Build.0 = Debug|NET100
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Release|NET100.ActiveCfg = Release|NET100
{0BC2A611-BD0E-4FCC-A1DE-81F14ED369B2}.Release|NET100.Build.0 = Release|NET100
{75940ACC-3708-4526-8D91-7E3365BAF682}.Debug|NET100.ActiveCfg = Debug|NET100
{75940ACC-3708-4526-8D91-7E3365BAF682}.Debug|NET100.Build.0 = Debug|NET100
{75940ACC-3708-4526-8D91-7E3365BAF682}.Release|NET100.ActiveCfg = Release|NET100
{75940ACC-3708-4526-8D91-7E3365BAF682}.Release|NET100.Build.0 = Release|NET100
{E4701F9E-41AB-4044-8166-85D924FEB632}.Debug|NET100.ActiveCfg = Debug|NET100
{E4701F9E-41AB-4044-8166-85D924FEB632}.Debug|NET100.Build.0 = Debug|NET100
{E4701F9E-41AB-4044-8166-85D924FEB632}.Release|NET100.ActiveCfg = Release|NET100
{E4701F9E-41AB-4044-8166-85D924FEB632}.Release|NET100.Build.0 = Release|NET100
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Debug|NET100.ActiveCfg = Debug|NET100
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Debug|NET100.Build.0 = Debug|NET100
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Release|NET100.ActiveCfg = Release|NET100
{9E79DC8D-25B1-491F-B094-EA39DE1BBC66}.Release|NET100.Build.0 = Release|NET100
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Debug|NET100.ActiveCfg = Debug|NET100
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Debug|NET100.Build.0 = Debug|NET100
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Release|NET100.ActiveCfg = Release|NET100
{AD0499ED-50D3-46F4-9FC9-3F71D88C4870}.Release|NET100.Build.0 = Release|NET100
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Debug|NET100.ActiveCfg = Debug|NET100
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Debug|NET100.Build.0 = Debug|NET100
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Release|NET100.ActiveCfg = Release|NET100
{06B9E5B0-7C50-4351-9D88-E159DC25755F}.Release|NET100.Build.0 = Release|NET100
{53D05530-CF64-4883-8F86-B2B819934F83}.Debug|NET100.ActiveCfg = Debug|NET100
{53D05530-CF64-4883-8F86-B2B819934F83}.Debug|NET100.Build.0 = Debug|NET100
{53D05530-CF64-4883-8F86-B2B819934F83}.Release|NET100.ActiveCfg = Release|NET100
{53D05530-CF64-4883-8F86-B2B819934F83}.Release|NET100.Build.0 = Release|NET100
{589F14D7-2937-479C-834A-D44197CB1930}.Debug|NET100.ActiveCfg = Debug|NET100
{589F14D7-2937-479C-834A-D44197CB1930}.Debug|NET100.Build.0 = Debug|NET100
{589F14D7-2937-479C-834A-D44197CB1930}.Release|NET100.ActiveCfg = Release|NET100
{589F14D7-2937-479C-834A-D44197CB1930}.Release|NET100.Build.0 = Release|NET100
{133FC760-5699-46D9-BEA6-E816B5F01016}.Debug|NET100.ActiveCfg = Debug|NET100
{133FC760-5699-46D9-BEA6-E816B5F01016}.Debug|NET100.Build.0 = Debug|NET100
{133FC760-5699-46D9-BEA6-E816B5F01016}.Release|NET100.ActiveCfg = Release|NET100
{133FC760-5699-46D9-BEA6-E816B5F01016}.Release|NET100.Build.0 = Release|NET100
{9ADADC68-36A3-4A21-9B54-298154A88720}.Debug|NET100.ActiveCfg = Debug|NET100
{9ADADC68-36A3-4A21-9B54-298154A88720}.Debug|NET100.Build.0 = Debug|NET100
{9ADADC68-36A3-4A21-9B54-298154A88720}.Release|NET100.ActiveCfg = Release|NET100
{9ADADC68-36A3-4A21-9B54-298154A88720}.Release|NET100.Build.0 = Release|NET100
{A31E274C-524A-40CA-85FF-595D3DB53777}.Debug|NET100.ActiveCfg = Debug|NET100
{A31E274C-524A-40CA-85FF-595D3DB53777}.Debug|NET100.Build.0 = Debug|NET100
{A31E274C-524A-40CA-85FF-595D3DB53777}.Release|NET100.ActiveCfg = Release|NET100
{A31E274C-524A-40CA-85FF-595D3DB53777}.Release|NET100.Build.0 = Release|NET100
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Debug|NET100.ActiveCfg = Debug|NET100
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Debug|NET100.Build.0 = Debug|NET100
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Release|NET100.ActiveCfg = Release|NET100
{92A46535-D870-4E1A-AED0-7492789E9C4A}.Release|NET100.Build.0 = Release|NET100
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
Loading