REVIT-251132 (#3415)#3416
Merged
Merged
Conversation
Mikhinja
commented
Jun 11, 2026
Mikhinja
commented
Collaborator
- forcefully close splash screen when closing Dynamo if during play of journal and it was still opened.
* forcefully close splash screen when closing Dynamo if during play of journal and it was still opened. --------- Co-authored-by: Vlad Catalina <vlad.catalina@autodesk.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses REVIT-251132 by ensuring the Dynamo splash screen does not remain open when Dynamo is closed during Revit journal replay, preventing automation/journal playback from getting stuck with an orphaned modal splash window.
Changes:
- On Dynamo view close, explicitly closes the splash screen if a journal is currently replaying and the splash screen is still referenced.
- Clears the
splashScreenreference after closing to avoid leaving stale state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AdrianaStanica
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.