Add GEOMETRIC GM parameterization support in MPAS-Ocean#8477
Open
hyungyukang wants to merge 8 commits into
Open
Add GEOMETRIC GM parameterization support in MPAS-Ocean#8477hyungyukang wants to merge 8 commits into
hyungyukang wants to merge 8 commits into
Conversation
hyungyukang
added
MPAS-ocean
Contributor
Author
|
GMPAS-JRA1p5 simulation results:
|
hyungyukang
requested review from
mark-petersen
and removed request for
mark-petersen
June 16, 2026 17:10
Added a new GEOMETRIC GM parameterization - It can be enabled with config_gm_closure = 'geometric'. - The current implementation uses a depth-integrated eddy energy formulation following Marshall et al. (2012) and Mak et al. (2018). - When enabled, gmKappaScaling varies both spatially and temporally. - Currently, only the "split_explicit_ab2" time stepper supports the new GM parameterization. - GEOMETRIC stands for Geometry and Energetics of Ocean Mesoscale Eddies and Their Rectified Impact on Climate.
hyungyukang
force-pushed
the
hkang/ocean/add-geometric-gm
branch
from
June 25, 2026 00:43
3183dd9 to
6925339
Compare
mark-petersen
approved these changes
Jul 14, 2026
mark-petersen
left a comment
mark-petersen
left a comment
Contributor
There was a problem hiding this comment.
@hyungyukang this looks great! The higher AMOC is a big success! This passes the nightly suite with gnu debug and optimized on perlmutter. All new code is protected by the config_GM_closure == 'geometric' flag. Thanks!
hyungyukang
marked this pull request as ready for review
July 14, 2026 22:51
Co-authored-by: Mark Petersen <mpetersen@lanl.gov>
Contributor
Author
|
@mark-petersen , thanks a lot for your review. I just committed your suggestions. Thanks a lot again! |
Contributor
|
@hyungyukang -- the test results to show impact would be better if they were fully-coupled, but this should be OK for a stealth feature. But we do need to add a new test to the stealth test suite that runs this on. Please let me know if you need help to do this |
Contributor
Author
|
@jonbob , Thanks. I’ll take care of it soon and reach out if I need any help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the GEOMETRIC GM parameterization as a new stealth GM parameterization option in MPAS-Ocean.
The option can be enabled with
config_gm_closure = 'geometric'.The current implementation uses a depth-integrated eddy energy formulation following Marshall et al. (2012) and Mak et al. (2018).
When this option is enabled,
gmKappaScalingvaries both spatially and temporally.At present, the new GM parameterization is supported only by
split_explicit_ab2, which is the default time stepper.The relevant namelist options for the GEOMETRIC GM parameterization are listed below. Details for each option are provided in
mpas-ocean/bld/namelist_files/namelist_definition_mpaso.xml.config_gm_closure = 'geometric'config_GM_geometric_alpha = 0.035config_GM_geometric_eddyDiff = 600.0config_GM_geometric_dissipation = 90.0config_GM_geometric_backgroundEddyEnergy = 0.1config_GM_geometric_maximumEddyEnergy = 1000.0config_gm_spatially_variable_max_kappa = 800.0config_gm_spatially_variable_min_kappa = 100.0GEOMETRIC stands for Geometry and Energetics of Ocean Mesoscale Eddies and Their Rectified Impact on Climate.
This work was carried out under the ImPACTS SciDAC project, led by @vanroekel.