Fix ZM Tests#8528
Merged
Merged
Conversation
whannah1
added
Atmosphere
Testing
whannah1
marked this pull request as draft
June 29, 2026 21:18
Contributor
|
whannah1
marked this pull request as ready for review
July 1, 2026 03:04
tcclevenger
reviewed
Jul 1, 2026
tcclevenger
approved these changes
Jul 1, 2026
tcclevenger
left a comment
tcclevenger
left a comment
Contributor
There was a problem hiding this comment.
I think we can move forward with this, it is just in unit testing functions and we can remove when we update to C++20 since intel compiler will not be in use.
Updated the comment regarding the Intel compiler bug workaround and added a note about future updates.
Moving this change to another PR
tcclevenger
added a commit
that referenced
this pull request
Jul 9, 2026
Various fixes for testing issues originating from PR #8421 which was a major ZM update. - The default value of use_fortran_bridge was not properly updated, so CIME tests with F2010xx-ZM were running the fortran bridge rather than the new C++ version of ZM. This does not explain any failure, but it was an oversight and is incorrect. - CIME tests with F2010xx-ZM fail on chrysalis due to a intel specific problem with the allocation of the "estbl" variable. The fix is certainly "hacky", but several alternatives were tested that did not fix the problem. The fix does not appear to negatively affect GPU builds. - ZM unit tests are failing due to a baseline generation problem, but an additional issue was discovered where the "old_snow" value for the fortran bridge was incorrectly set. The default value of this parameter changed n the previous PR, so a diff was expected, but it was expected to be fixed by a bless, which is not what happened. The current old_snow update, plus another bless, should resolve the issue. [non-BFB] for ZM tests and F2010xx-ZM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes for testing issues originating from PR #8421 which was a major ZM update.
use_fortran_bridgewas not properly updated, so CIME tests with F2010xx-ZM were running the fortran bridge rather than the new C++ version of ZM. This does not explain any failure, but it was an oversight and is incorrect.old_snowupdate, plus another bless, should resolve the issue.[non-BFB] for ZM tests and F2010xx-ZM