Apply ingestion state during archive discovery#260
Open
tomvothecoder wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the NERSC archive ingestor’s discovery phase to apply persisted ingestion state earlier (during directory discovery) so previously processed execution IDs are skipped before validation, while keeping discovery/logging counters consistent and preserving merged processed state after ingestion.
Changes:
- Apply “already processed” filtering during archive execution discovery via a precomputed
processed_ids_by_keymapping. - Add and propagate a new discovery/logging counter:
rejected_existing_execution_ids. - Merge previously processed execution IDs into persisted state after successful ingestion (instead of overwriting).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/app/scripts/ingestion/nersc_archive_ingestor.py | Skips known execution IDs earlier during discovery, logs new counter fields, and merges processed execution IDs when recording successful ingestions. |
| backend/tests/features/ingestion/test_nersc_archive_ingestor.py | Extends assertions for the new counter and adds coverage for early skipping of previously processed archive execution IDs. |
Collaborator
Author
|
Summary: Looks correct for an early-state dry run. Also cut down time from ~309s to ~223s (original run without early state check).
|
Collaborator
Author
|
@TonyB9000 I used Codex to address #238, which it did relatively quickly. I performed a test run above and all seems well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply ingestion state during archive discovery so known execution IDs skip earlier and archive scan counters stay consistent.
Checklist
Deployment Notes (if any)
None.