fix: 250930 수정요청사항 (#248)

* feat: 자장밥 필터링 안되게 추가

* refactor: /v2/reviews/my swagger json 깨지는 문제 수정

* refactor: valid-for-review swagger menulist 수정

* refactor: /list/menu mainRating->rating, 맛/양 rating 필드 삭제

* chore: 코드 포맷팅

* refactor: mainRating->rating으로 필드 변경

* /list/menu에 id,name,isLike추가

* fix: gemini 리뷰 반영

Author: JjungminLee

src/main/java/ssu/eatssu/domain/auth/infrastructure/SecurityConfig.java

@@ -14,7 +14,6 @@
 import org.springframework.web.cors.UrlBasedCorsConfigurationSource;
 import ssu.eatssu.domain.auth.security.JwtAuthenticationFilter;
 import ssu.eatssu.domain.auth.security.JwtTokenProvider;
-import ssu.eatssu.domain.slack.service.SlackErrorNotifier;
 import ssu.eatssu.global.handler.JwtAccessDeniedHandler;
 import ssu.eatssu.global.handler.JwtAuthenticationEntryPoint;
 

src/main/java/ssu/eatssu/domain/auth/security/JwtAuthenticationFilter.java

@@ -15,8 +15,6 @@
 import org.springframework.util.StringUtils;
 import org.springframework.web.filter.GenericFilterBean;
 
-
-
 import java.io.IOException;
 import java.util.List;
 

src/main/java/ssu/eatssu/domain/menu/entity/Menu.java

@@ -33,6 +33,8 @@ public class Menu {
     private final Reviews reviews = new Reviews();
     @OneToMany(mappedBy = "menu", cascade = CascadeType.ALL)
     private final List<MealMenu> mealMenus = new ArrayList<>();
+    @Column(name = "unlike_count")
+    private Integer unlikeCount = 0;
     @Id
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     @Column(name = "menu_id")
@@ -44,15 +46,10 @@ public class Menu {
     @ManyToOne(fetch = FetchType.LAZY)
     @JoinColumn(name = "menu_category_id")
     private MenuCategory category;
-
     private boolean isDiscontinued = false;
-
     @Column(name = "like_count")
     private Integer likeCount = 0;
 
-    @Column(name = "unlike_count")
-    private final Integer unlikeCount = 0;
-
     private Menu(String name, Restaurant restaurant, Integer price, MenuCategory category) {
         this.name = name;
         this.restaurant = restaurant;

src/main/java/ssu/eatssu/domain/menu/persistence/QuerydslMenuRatingCalculator.java

@@ -27,7 +27,6 @@ public Double getMainRatingAverage(Long menuId) {
     }
 
 
-
     private BooleanExpression menuIdEq(Long menuId) {
         return menu.id.eq(menuId);
     }

src/main/java/ssu/eatssu/domain/partnership/dto/PartnershipInfo.java

@@ -28,9 +28,11 @@ public static PartnershipInfo fromEntity(Partnership partnership,
                               .startDate(partnership.getStartDate())
                               .endDate(partnership.getEndDate())
                               .collegeName(partnership.getPartnershipCollege() == null && partnership.getPartnershipDepartment() == null
-                                                ? "총학생회"
-                                                : (partnership.getPartnershipCollege() != null ? partnership.getPartnershipCollege().getName() : null))
-                              .departmentName(partnership.getPartnershipDepartment() != null ? partnership.getPartnershipDepartment().getName() : null)
+                                                   ? "총학생회"
+                                                   : (partnership.getPartnershipCollege() != null ? partnership.getPartnershipCollege()
+                                                                                                               .getName() : null))
+                              .departmentName(partnership.getPartnershipDepartment() != null ? partnership.getPartnershipDepartment()
+                                                                                                          .getName() : null)
                               .likeCount(restaurant.getLikes() != null ? restaurant.getLikes().size() : 0)
                               .isLiked(isLiked)
                               .build();

src/main/java/ssu/eatssu/domain/partnership/entity/Partnership.java

@@ -2,8 +2,6 @@
 
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
-import jakarta.persistence.EnumType;
-import jakarta.persistence.Enumerated;
 import jakarta.persistence.FetchType;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.GenerationType;
@@ -32,7 +30,7 @@ public class Partnership {
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     @Column(name = "partnership_id")
     private Long id;
-    
+
     @Column(name = "description", nullable = false)
     private String description;
 

src/main/java/ssu/eatssu/domain/partnership/persistence/PartnershipRepository.java

@@ -12,19 +12,19 @@
 
 public interface PartnershipRepository extends JpaRepository<Partnership, Long> {
     @Query("""
-        select distinct pr
-        from PartnershipRestaurant pr
-        join fetch pr.partnerships p
-        left join fetch p.partnershipCollege pc
-        left join fetch p.partnershipDepartment pd
-        where
-          (
-            pc = :college
-            or pd = :department
-            or (pc is null and pd is null)
-          )
-          and (p.endDate is null or p.endDate >= current_date)
-        """)
+            select distinct pr
+            from PartnershipRestaurant pr
+            join fetch pr.partnerships p
+            left join fetch p.partnershipCollege pc
+            left join fetch p.partnershipDepartment pd
+            where
+              (
+                pc = :college
+                or pd = :department
+                or (pc is null and pd is null)
+              )
+              and (p.endDate is null or p.endDate >= current_date)
+            """)
     List<PartnershipRestaurant> findRestaurantsWithMyPartnerships(
             @Param("college") College college,
             @Param("department") Department department

src/main/java/ssu/eatssu/domain/restaurant/entity/Restaurant.java

@@ -15,7 +15,7 @@ public enum Restaurant {
     FOOD_COURT("FOOD_COURT", null),
     SNACK_CORNER("SNACK_CORNER", null),
     HAKSIK("HAKSIK", 5000),
-    FACULTY("FACULTY",null);
+    FACULTY("FACULTY", null);
 
     private final String restaurantName;
     private final Integer restaurantPrice;

src/main/java/ssu/eatssu/domain/review/dto/CreateMenuReviewRequest.java

@@ -6,7 +6,6 @@
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
-import org.springframework.util.Assert;
 import ssu.eatssu.domain.menu.entity.Menu;
 import ssu.eatssu.domain.rating.entity.Ratings;
 import ssu.eatssu.domain.review.entity.Review;

src/main/java/ssu/eatssu/domain/review/dto/MealReviewResponse.java

@@ -42,7 +42,20 @@ public class MealReviewResponse {
     @Schema(description = "리뷰 이미지 url 리스트", example = "[\"imgurl1\", \"imgurl2\"]")
     private List<String> imageUrls;
 
-    @Schema(description = "메뉴 리스트")
+    @Schema(description = "메뉴 리스트", example = """
+            [
+              {
+                "menuId": 3143,
+                "name": "생고기제육볶음",
+                "isLike": true
+              },
+              {
+                "menuId": 3144,
+                "name": "오징어초무침",
+                "isLike": false
+              }
+            ]
+            """)
     private List<MenuIdNameLikeDto> menuList;
 
     public static MealReviewResponse from(Review review,