Skip to content

Commit 1934cba

Browse files
authored
refactor: 리뷰 생성에 검증자 추가 (#256)
Co-authored-by: 나용준 <141994188+youngJun99@users.noreply.github.com>
1 parent 3aadb52 commit 1934cba

3 files changed

Lines changed: 16 additions & 4 deletions

File tree

src/main/java/ssu/eatssu/domain/review/dto/CreateMealReviewRequest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package ssu.eatssu.domain.review.dto;
22

33
import io.swagger.v3.oas.annotations.media.Schema;
4+
import jakarta.validation.constraints.Max;
5+
import jakarta.validation.constraints.Min;
46
import lombok.AllArgsConstructor;
57
import lombok.Getter;
68
import ssu.eatssu.domain.menu.entity.Meal;
@@ -18,6 +20,8 @@ public class CreateMealReviewRequest {
1820
@Schema(description = "식단 식별자", example = "123")
1921
private Long mealId;
2022
@Schema(description = "평점", example = "4")
23+
@Min(1)
24+
@Max(5)
2125
private Integer rating;
2226
private List<MenuLikeRequest> menuLikes;
2327
@Schema(description = "한줄평", example = "맛있어용")

src/main/java/ssu/eatssu/domain/review/dto/CreateMenuReviewRequest.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import io.swagger.v3.oas.annotations.media.Schema;
44
import jakarta.validation.constraints.Max;
5+
import jakarta.validation.constraints.Min;
56
import lombok.AccessLevel;
67
import lombok.Getter;
78
import lombok.NoArgsConstructor;
@@ -19,10 +20,16 @@ public class CreateMenuReviewRequest {
1920
@Schema(description = "메뉴 식별자", example = "123")
2021
private Long menuId;
2122
@Schema(description = "평점-메인", example = "4")
23+
@Min(1)
24+
@Max(5)
2225
private Integer mainRating;
23-
@Schema(description = "평점-맛", example = "4")
24-
private Integer amountRating;
2526
@Schema(description = "평점-양", example = "4")
27+
@Min(1)
28+
@Max(5)
29+
private Integer amountRating;
30+
@Schema(description = "평점-맛", example = "4")
31+
@Min(1)
32+
@Max(5)
2633
private Integer tasteRating;
2734
@Max(150)
2835
@Schema(description = "한줄평", example = "맛있어용")

src/main/java/ssu/eatssu/domain/review/presentation/ReviewControllerV2.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.swagger.v3.oas.annotations.responses.ApiResponse;
99
import io.swagger.v3.oas.annotations.responses.ApiResponses;
1010
import io.swagger.v3.oas.annotations.tags.Tag;
11+
import jakarta.validation.Valid;
1112
import lombok.RequiredArgsConstructor;
1213
import org.springdoc.core.annotations.ParameterObject;
1314
import org.springframework.data.domain.PageRequest;
@@ -56,7 +57,7 @@ public class ReviewControllerV2 {
5657
})
5758
@PostMapping("/meal")
5859
public BaseResponse<?> createMealReview(
59-
@RequestBody CreateMealReviewRequest createMealReviewRequest,
60+
@Valid @RequestBody CreateMealReviewRequest createMealReviewRequest,
6061
@AuthenticationPrincipal CustomUserDetails customUserDetails) {
6162
reviewServiceV2.createMealReview(customUserDetails, createMealReviewRequest);
6263
return BaseResponse.success();
@@ -205,7 +206,7 @@ public BaseResponse<SliceResponse<ReviewDetail>> getMenuReviewList(
205206
@ApiResponse(responseCode = "404", description = "존재하지 않는 유저", content = @Content(schema = @Schema(implementation = BaseResponse.class))),
206207
})
207208
@PostMapping("/menu")
208-
public BaseResponse<?> createMenuReview(@RequestBody CreateMenuReviewRequest createMenuReviewRequest,
209+
public BaseResponse<?> createMenuReview(@Valid @RequestBody CreateMenuReviewRequest createMenuReviewRequest,
209210
@AuthenticationPrincipal CustomUserDetails customUserDetails) {
210211
reviewServiceV2.createMenuReview(customUserDetails, createMenuReviewRequest);
211212
return BaseResponse.success();

0 commit comments

Comments
 (0)