Hot fix to not send empty link type (#443)

Néstor Diaz · web-flow · commit 2ec6d8a27c21 · 2020-12-10T14:25:14.000Z
diff --git a/src/app/pages/submission/submission-shared/model/pagetab/pagetab-links.utils.ts b/src/app/pages/submission/submission-shared/model/pagetab/pagetab-links.utils.ts
@@ -31,7 +31,6 @@ export class LinksUtils {
       attributes: attributes.filter((at) => ![TYPE_ATTR, POINTER_ATTR].includes(at.name!) && !isAttributeEmpty(at))
     } as PtLink;
 
-    linkObj.attributes!.push(typeAttr);
     if (pointer) {
       if (isUrl) {
         linkObj.url = pointer;
@@ -48,6 +47,10 @@ export class LinksUtils {
       }
     }
 
+    if (!isAttributeEmpty(typeAttr)) {
+      linkObj.attributes!.push(typeAttr);
+    }
+
     return linkObj;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ export class LinksUtils {`
`31`	`31`	`attributes: attributes.filter((at) => ![TYPE_ATTR, POINTER_ATTR].includes(at.name!) && !isAttributeEmpty(at))`
`32`	`32`	`} as PtLink;`
`33`	`33`
`34`		`- linkObj.attributes!.push(typeAttr);`
`35`	`34`	`if (pointer) {`
`36`	`35`	`if (isUrl) {`
`37`	`36`	`linkObj.url = pointer;`
`@@ -48,6 +47,10 @@ export class LinksUtils {`
`48`	`47`	`}`
`49`	`48`	`}`
`50`	`49`
	`50`	`+ if (!isAttributeEmpty(typeAttr)) {`
	`51`	`+ linkObj.attributes!.push(typeAttr);`
	`52`	`+ }`
	`53`	`+`
`51`	`54`	`return linkObj;`
`52`	`55`	`}`
`53`	`56`