Skip to content

Commit d943a09

Browse files
committed
Merge branch 'hotfix/1.1.1'
2 parents 782ff6b + 9d4f1dd commit d943a09

2 files changed

Lines changed: 27 additions & 27 deletions

File tree

src/service/FrameService.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -241,29 +241,29 @@ class FrameService {
241241
this.setupNavbarForCurrentPage();
242242

243243
if (!Storage.getSettings<boolean>(Settings.SHARE_BOUNDS)) {
244-
frame.isMaximized() && this.toggleMaximize();
244+
frame.isMaximized() && frame.unmaximize();
245245
const bounds = PageService.getPageBounds(page);
246246
frame.setBounds(bounds);
247247
}
248248

249+
this.ensureWindowVisible(frame);
249250
this.updateChildrenBounds();
250251

251252
const dragHandle = Draggable.from(frame);
252253
const navbar = NavbarService.getView();
253-
if (navbar) {
254+
if (navbar && frame.contentView.children.length === 0) {
254255
frame.contentView.addChildView(navbar);
255-
dragHandle.attach(navbar.webContents, {
256-
exclude: 'button',
257-
});
256+
dragHandle.attach(navbar.webContents, { exclude: 'button' });
258257
} else {
259258
dragHandle.attach(newView.webContents, {
260-
region: { height: Storage.getSettings(Settings.ACTION_AREA) as number },
259+
region: { height: Storage.getSettings<number>(Settings.ACTION_AREA) },
261260
exclude: 'button, a, input, select, textarea',
262261
});
263262
}
263+
264264
this.safeDisplay(frame, newView);
265265
this.buildViewFindbar(newView);
266-
show && this.show();
266+
show && !frame.isVisible() && this.show();
267267
}
268268

269269
private safeDisplay(frame: BaseWindow, view: PageView): void {

web/preferences/components/settings/Settings.js

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,26 @@ app.component('Settings', {
9797
description: s.actionAreaDesc,
9898
data: { type: 'number', min: 0, value: await storage.getSettings(this.$const.Settings.ACTION_AREA), unit: 'px' }
9999
},
100+
{
101+
id: this.$const.Settings.USE_EXTERNAL_BROWSER,
102+
label: s.useExternalBrowser,
103+
description: s.useExternalBrowserDesc,
104+
data: { type: 'bool', value: await storage.getSettings(this.$const.Settings.USE_EXTERNAL_BROWSER) }
105+
},
106+
{
107+
id: this.$const.Settings.GROUP_PAGES_BY_SESSION,
108+
label: s.groupPagesBySession,
109+
description: s.groupPagesBySessionDesc,
110+
data: { type: 'bool', value: await storage.getSettings(this.$const.Settings.GROUP_PAGES_BY_SESSION) }
111+
},
112+
{
113+
id: this.$const.Settings.ALLOW_FULLSCREEN,
114+
label: s.allowFullscreen,
115+
description: s.allowFullscreenDesc,
116+
data: { type: 'bool', value: await storage.getSettings(this.$const.Settings.ALLOW_FULLSCREEN) }
117+
}
118+
],
119+
[s.appearance]: [
100120
{
101121
id: this.$const.Settings.APP_THEME,
102122
label: s.appTheme,
@@ -126,26 +146,6 @@ app.component('Settings', {
126146
]
127147
}
128148
},
129-
{
130-
id: this.$const.Settings.USE_EXTERNAL_BROWSER,
131-
label: s.useExternalBrowser,
132-
description: s.useExternalBrowserDesc,
133-
data: { type: 'bool', value: await storage.getSettings(this.$const.Settings.USE_EXTERNAL_BROWSER) }
134-
},
135-
{
136-
id: this.$const.Settings.GROUP_PAGES_BY_SESSION,
137-
label: s.groupPagesBySession,
138-
description: s.groupPagesBySessionDesc,
139-
data: { type: 'bool', value: await storage.getSettings(this.$const.Settings.GROUP_PAGES_BY_SESSION) }
140-
},
141-
{
142-
id: this.$const.Settings.ALLOW_FULLSCREEN,
143-
label: s.allowFullscreen,
144-
description: s.allowFullscreenDesc,
145-
data: { type: 'bool', value: await storage.getSettings(this.$const.Settings.ALLOW_FULLSCREEN) }
146-
}
147-
],
148-
[s.appearance]: [
149149
{
150150
id: this.$const.Settings.SHOW_FRAME,
151151
label: s.showFrame,

0 commit comments

Comments
 (0)