Skip to content

Commit 741f406

Browse files
authored
update minimum python version to 3.10 to avoid EoL versions (#328)
* update minimum python version to 3.10 to avoid EoL versions * update requirements listed in README * remove unnecesary global definition
1 parent 5e7b4b4 commit 741f406

4 files changed

Lines changed: 11 additions & 12 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ jobs:
1313
runs-on: ubuntu-latest
1414

1515
steps:
16-
- uses: actions/checkout@v3
16+
- uses: actions/checkout@v6
1717

18-
- name: Set up Python 3.8
19-
uses: actions/setup-python@v3
18+
- name: Set up Python 3.10
19+
uses: actions/setup-python@v6
2020
with:
21-
python-version: "3.8"
21+
python-version: "3.10"
2222

2323
- name: Install dependencies
2424
run: |
@@ -40,13 +40,13 @@ jobs:
4040
fail-fast: false
4141
max-parallel: 5
4242
matrix:
43-
python-version: ["3.8", "3.9", "3.10", "3.11"]
43+
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
4444

4545
steps:
46-
- uses: actions/checkout@v3
46+
- uses: actions/checkout@v6
4747

4848
- name: Set up Python ${{ matrix.python-version }}
49-
uses: actions/setup-python@v3
49+
uses: actions/setup-python@v6
5050
with:
5151
python-version: ${{ matrix.python-version }}
5252

@@ -75,7 +75,7 @@ jobs:
7575
- uses: actions/checkout@master
7676

7777
- name: Set up Python 3.10
78-
uses: actions/setup-python@v3
78+
uses: actions/setup-python@v6
7979
with:
8080
python-version: "3.10"
8181

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ See [Getting started with impedance.py](https://impedancepy.readthedocs.io/en/la
2929

3030
impedance.py requires:
3131

32-
- Python (>=3.7)
32+
- Python (>=3.10)
3333
- SciPy (>=1.0)
3434
- NumPy (>=1.22.4)
35-
- Matplotlib (>=3.0)
35+
- Matplotlib (>=3.5)
3636
- Altair (>=3.0)
3737
- Pandas
3838

impedance/models/circuits/elements.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ def wrapper(p, f):
3333
wrapper.__name__ = func.__name__
3434
wrapper.__doc__ = func.__doc__
3535

36-
global circuit_elements
3736
if func.__name__ in ["s", "p"]:
3837
raise ElementError("cannot redefine elements 's' (series)" +
3938
"or 'p' (parallel)")

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
long_description_content_type="text/markdown",
1515
url="https://impedancepy.readthedocs.io/en/latest/",
1616
packages=setuptools.find_packages(),
17-
python_requires="~=3.8",
17+
python_requires="~=3.10",
1818
install_requires=['altair>=3.0', 'matplotlib>=3.5',
1919
'numpy>=1.22.4', 'scipy>=1.0',
2020
'pandas'],

0 commit comments

Comments
 (0)