Fix a possible bug that could allow an EDDN state with a systemAddress of zero (due to a shallow copy of the EDDN state rather than a deep copy).

Author: Tkael

EDDNResponder/EDDNState.cs

@@ -15,16 +15,6 @@ public EDDNState()
             Location = new LocationAugmenter();
         }
 
-        /// <summary>
-        /// Copy constructor
-        /// </summary>
-        /// <param name="eddnState"></param>
-        public EDDNState ( EDDNState eddnState )
-        {
-            GameVersion = eddnState.GameVersion;
-            Location = eddnState.Location;
-        }
-
         public void GetStateInfo ( string edType, IDictionary<string, object> data )
         {
             // Attempt to obtain available game version data from the active event 

EDDNResponder/Schemas/FSSSignalDiscoveredSchema.cs

@@ -30,8 +30,8 @@ public bool Handle(string edType, ref IDictionary<string, object> data, EDDNStat
                 if ( eddnStates.All( s => s.Location?.systemAddress != eddnState.Location?.systemAddress ) &&
                      eddnState.Location.StarSystemLocationIsSet() )
                 {
-                    // Add a copy of the current EDDN state
-                    eddnStates.Add( new EDDNState( eddnState ) );
+                    // Add a deep copy of the current EDDN state
+                    eddnStates.Add( eddnState.Copy() );
                 }
 
                 if ( !edTypes.Contains( edType ) )