Skip to content

Commit 713b6da

Browse files
authored
Apply suggestions from code review
1 parent 14e83a1 commit 713b6da

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

docs/blog/posts/2025/12/gh-ci-workflow-for-EESSI.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ runs:
140140
```
141141

142142
A workflow that calls this action will load software from an EESSI stack (argument `modules`)
143-
and install Python packages from Pypi (argument `extra-python-packages`).
143+
and install Python packages from PyPI (argument `extra-python-packages`).
144144
Packages are managed by a Lmod [module collection](https://lmod.readthedocs.io/en/latest/010_user.html#rules-for-loading-modules-from-a-collection)
145145
and by a Python [virtual environment](https://docs.python.org/3/library/venv.html).
146146

@@ -150,7 +150,7 @@ The steps can be broken down as follows:
150150
* line 14 can be removed when only the `software.eessi.io` repository is needed
151151
* microarchitecture `x86_64/amd/zen2` is selected, which is forward-compatible with the Zen3 microarchitecture
152152
available on [standard GitHub-hosted runners](https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories)
153-
* Ubuntu ARM64 runners have microarchitecture `aarch64/nvidia/grace`
153+
* Ubuntu ARM64 runners have microarchitecture compatible with the `aarch64/nvidia/grace` software stack that EESSI ships
154154
* load the list of EESSI modules provided by the workflow and stash them to a collection called `espresso`
155155
* create a Python virtual environment that gives priority to Python packages available in EESSI
156156
(`venv` option `--system-site-packages`, other package managers have a different syntax)
@@ -159,7 +159,7 @@ The steps can be broken down as follows:
159159
`requirements.txt`, pip install them, and restore `requirements.txt`
160160
* clean up the session
161161

162-
This action allows us to hide the logic for package installation,
162+
This action allows us to "hide" the logic for package installation,
163163
and should only be edited by project maintainers.
164164
Project developers can ignore this file and focus on the workflow, described in the next section.
165165

0 commit comments

Comments
 (0)