Skip to content

Commit 4335060

Browse files
authored
Merge pull request #347 from trz42/address_pinned_dependencies
fix dependency versions for npm and Docker
2 parents 1710eb6 + aa08fae commit 4335060

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

.github/workflows/markdown-lint.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#
1111

1212
name: Markdown Lint
13-
on: [push, pull_request]
13+
on: [push, pull_request, workflow_dispatch]
1414
# Declare default permissions as read only.
1515
permissions: read-all
1616

@@ -24,10 +24,11 @@ jobs:
2424
- name: Setup Node.js
2525
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.0
2626
with:
27-
node-version: '18'
27+
node-version: '20'
2828

2929
- name: Install markdownlint-cli
30-
run: npm install -g markdownlint-cli
30+
run: npm install -g igorshubovych/markdownlint-cli#192ad822316c3a22fb3d3cc8aa6eafa0b8488360 # v0.45.0
31+
# SHA from https://github.com/igorshubovych/markdownlint-cli/commit/192ad822316c3a22fb3d3cc8aa6eafa0b8488360
3132

3233
- name: Run markdownlint
33-
run: markdownlint "**/*.md" --ignore .git
34+
run: markdownlint "**/*.md" --ignore .git

containers/Dockerfile.smee-client

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
1-
ARG smee_client_version=4.2.1
1+
ARG smee_client_version=4.4.1
2+
# ARG smee_client_version_commit=b837fa85fd05853731160e21356ffd30c8c3e791 # v4.4.1
23

3-
FROM node:lts-alpine
4+
# pinning base image to specific hash (corresponding to lts-alpine)
5+
FROM node@sha256:f36fed0b2129a8492535e2853c64fbdbd2d29dc1219ee3217023ca48aebd3787
46
ARG smee_client_version
7+
# ARG smee_client_version_commit
8+
9+
# Then install
510
RUN npm install --global smee-client@${smee_client_version}
611
ENTRYPOINT ["smee"]
712
CMD ["--help"]

0 commit comments

Comments
 (0)