Skip to content

use bot name as namespace#308

Merged
ocaisa merged 8 commits intoEESSI:developfrom
trz42:use_bot_name_as_namespace
Mar 17, 2025
Merged

use bot name as namespace#308
ocaisa merged 8 commits intoEESSI:developfrom
trz42:use_bot_name_as_namespace

Conversation

@trz42
Copy link
Copy Markdown
Contributor

@trz42 trz42 commented Mar 14, 2025

Use the bot instance's name as the namespace when signing files. Both sign and verify steps are updated. The verification is also prepared to support additional options such as valid-before.

CI tests are adjusted and extended to cover new functionality.

Part of CI output (added tests):

Verifying the signature against allowed signers...
Checking principal: wrong_namespace_identity and namespace: CI
Couldn't verify signature: namespace does not match
Could not verify signature.
Error: No valid signature found.
Expected failure for wrong namespace
Verifying the signature against allowed signers...
Checking principal: expired_key_identity and namespace: ci
allowed_signers:1: key has expired: verify time 2025-03-14T21:23:43 > valid-before 2025-03-11T00:00:00
Could not verify signature.
Error: No valid signature found.
Expected failure for expired key

Comment thread scripts/eessi-upload-to-staging Outdated
Comment thread scripts/sign_verify_file_ssh.sh Outdated
Comment thread scripts/sign_verify_file_ssh.sh
Comment thread scripts/sign_verify_file_ssh.sh
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests catch all the expected behaviours (at least for the EESSI use case)

@ocaisa ocaisa merged commit 5a97702 into EESSI:develop Mar 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants