revise README.md and app.cfg.example#325
Merged
Merged
Conversation
Neves-P
requested changes
Jun 26, 2025
Member
Neves-P
left a comment
Neves-P
left a comment
There was a problem hiding this comment.
Nice, this PR definitely makes the whole setup clearer!
I reworded or expanded a few points, but nothing major. Feel free to reject or modify the suggestions further if you feel like they are not relevant or could be better.
Co-authored-by: Pedro Santos Neves <10762799+Neves-P@users.noreply.github.com>
Keep linter happy
Member
|
Pushed a very small commit to keep the (great new!) linter happy. The checks pass, so I'll go ahead and merge this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR looks large, but it contains mostly polishing changes and updates that were missing in previous PRs/releases.
README.mdandapp.cfg.exampleso they include all current configuration settings.README.md(cleaning up old stuff, pointing to new EESSI-built container for the Smee client, etc.)README.md