support for template values in scontrol command #327
Merged
Conversation
Signed-off-by: laraPPr <lara.peeters@ugent.be>
boegel
requested changes
Aug 4, 2025
Signed-off-by: laraPPr <lara.peeters@ugent.be>
Signed-off-by: laraPPr <lara.peeters@ugent.be>
Signed-off-by: laraPPr <lara.peeters@ugent.be>
boegel
previously requested changes
Aug 4, 2025
Signed-off-by: laraPPr <lara.peeters@ugent.be>
Signed-off-by: laraPPr <lara.peeters@ugent.be>
Signed-off-by: laraPPr <lara.peeters@ugent.be>
trz42
previously requested changes
Aug 6, 2025
Contributor
trz42
left a comment
trz42
left a comment
There was a problem hiding this comment.
Looks good to me.
Added a small suggestion regarding a comment. Great if you could update app.cfg.example and README.md
Co-authored-by: Thomas Röblitz <trz42@users.noreply.github.com>
casparvl
reviewed
Aug 6, 2025
casparvl
requested changes
Aug 6, 2025
Contributor
casparvl
left a comment
casparvl
left a comment
There was a problem hiding this comment.
I can confirm it doesn't break my existing bot: casparvl/software-layer#2 (comment)
But I'm puzzled as to the use-case, please clarify in the README.md what valid placeholders are in the control_command and why one might need to have placeholders in there.
Signed-off-by: laraPPr <lara.peeters@ugent.be>
casparvl
reviewed
Aug 19, 2025
Co-authored-by: Caspar van Leeuwen <33718780+casparvl@users.noreply.github.com>
laraPPr
commented
Aug 19, 2025
Collaborator
Author
laraPPr
left a comment
laraPPr
left a comment
There was a problem hiding this comment.
Can this sentense be a little streamlined. I was having dificulty reading it.
Co-authored-by: Caspar van Leeuwen <33718780+casparvl@users.noreply.github.com>
casparvl
approved these changes
Aug 19, 2025
Signed-off-by: laraPPr <lara.peeters@ugent.be>
casparvl
dismissed stale reviews from trz42 and boegel
Changes were implemented
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works but I'm not sure if the code now the code seems to specified to our systems. But it works.
Should still add some debugging if this seems like a good way to go forward. becuase now the but crashes if it has an unknow placeholder in the string that is set in
app.cfg.