Add option to bot:status to print the status only for the last build#334
Conversation
…for each 'for' architecture
…n support bot:status last_build. Then, implement functionality in the status command that makes sure only the last build result for each architecture is printed
…ned. Also, log the general args to the log
…composing the table with only the last builds. Finally, add resorting for an output that is sorted alphabetically by 'for' architecture
trz42
left a comment
There was a problem hiding this comment.
Two comments before having looked into this in detail:
- Since we now use multiple bot instances it might be good to include the instance name in the overview table.
- If a build succeeded for an architecture, then a follow-up failed, the table would show the last build as failed while setting the
bot:deploylabel would lead to the last successful one being uploaded. Not sure if that would happen often and how to approach that issue.
|
Hm, initially I wanted to mimic as closely as possible what the bot does for the 'deploy last' policy. I concluded that was not possible, because the status command solely relies on issue comments, and not on any variables that are in memory (which the deployment policy does, it checks state in the job dir etc). But I now realize I don't need that: the status is one of the items in the table, so I have that information. Should not be too hard to modify the behavior to pick the last success, rather than the last build. That mimics the deployment behavior more closely, which I agree is preferable. Regarding the instance name: should be doable: it's in the same issue comment as the rest of the build info, so should be trivial to capture. |
|
As discussed online, we should get the PR merged as is and postpone potential improvements to a subsequent release. |
trz42
left a comment
There was a problem hiding this comment.
Looks good to me and already improves the current situation / ability to obtain a concise status overview.
If we find that some of the comments need to be addressed, those can be taken up later through a follow up PR.
|
@casparvl I tried this on our local bot after checking out edit: let's follow-up on that via #338 |
This PR implements functionality so that one can do:
Which will create a status table only contain the last build for each
forarchitecture. This makes it much easier to check if all architectures have been (successfully) build for in a given PR. That's almost essential for GPU builds, where the number of target architectures is currently 13 (CPU) * 3 (GPU) = 39 architectures.This example was created with a bot running from this commit
Fixes #332