Skip to content

don't replace self.scontrol_command in process_new_job#335

Merged
laraPPr merged 2 commits into
EESSI:developfrom
boegel:fix_templated_scontrol_command
Aug 20, 2025
Merged

don't replace self.scontrol_command in process_new_job#335
laraPPr merged 2 commits into
EESSI:developfrom
boegel:fix_templated_scontrol_command

Conversation

@boegel
Copy link
Copy Markdown
Contributor

@boegel boegel commented Aug 20, 2025

required bug fix for enhancement implemented in #327, to keep placeholder and allow processing jobs that require different placeholder values

Without this, the first job that's processed determines the value for a placeholder like %(cluster)s, but multiple jobs being processed/released in sequence may belong to different clusters

…holder and allow processing jobs that require different placeholder values
@boegel boegel added the bug label Aug 20, 2025
Copy link
Copy Markdown
Collaborator

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr laraPPr merged commit 5656a69 into EESSI:develop Aug 20, 2025
5 checks passed
@boegel boegel deleted the fix_templated_scontrol_command branch August 20, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants