-
Notifications
You must be signed in to change notification settings - Fork 23
merging develop into main for release v0.9.0
#339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
162 commits
Select commit
Hold shift + click to select a range
a444bcc
add support for cloning Git repository via SSH rather than HTTPS
boegel 6dcdd80
fix use of config.BUILDENV_SETTING_CLONE_GIT_REPO_VIA
boegel 3f2cfcb
also use clone_git_repo_via in app.cfg.example
boegel 37c06af
mark clone_git_repo_via as optional + add logging
boegel 4b046f6
fix get_build_env_cfg to get clone_git_repo_via value from buildenv i…
boegel 45bd556
remove curl command to obtain PR diff + fix _ERROR_GIT_CLONE constant
boegel b19fe23
fix return value for 'git diff' command in download_pr function
boegel 5c51665
make sure that download_comment is defined in comment_download_pr
boegel a1c2635
fix 'git diff' command in download_repo
boegel 02f3125
fix branch name used by 'git diff' command
boegel 47e2076
Merge branch 'main' into git_clone_via_ssh
boegel c7a98f2
comment out clone_git_repo_via setting in REQUIRED_CONFIG to avoid ma…
boegel 7da317d
fix order in REQUIRED_CONFIG (recommended settings before optional ones)
boegel 293ce3c
add more info on use case of clone_git_repo_via set to 'ssh'
boegel 668915c
also add more info on use case of clone_git_repo_via set to 'ssh' to …
boegel 882354c
Merge branch 'git_clone_via_ssh' of github.com:boegel/eessi-bot-softw…
boegel a99ae60
only use 'git diff' to obtain PR diff when 'ssh' is used to clone rep…
boegel 9b582ab
git diff from merge-base instead of from HEAD
smoors 4415afc
Make a first attempt to change the expected arch_target_map. Make sur…
d3240e4
Remove old code that was replaced
1ea33d9
Merge pull request #1 from smoors/pr300
boegel df1a258
Merge branch 'develop' into git_clone_via_ssh
boegel 46d14a9
Merge branch 'git_clone_via_ssh' of github.com:boegel/eessi-bot-softw…
boegel f4c0940
update README
smoors 4021c20
Merge pull request #2 from smoors/pr300
boegel 4a3dd94
Merge branch 'develop' into git_clone_via_ssh
boegel e30cd5b
Merge branch 'git_clone_via_ssh' of github.com:boegel/eessi-bot-softw…
boegel bc5c154
workflow for building a smee-client container image
bedroge 57fb5ed
dockerfile for smee-client container
bedroge 7ac0dd1
also trigger for PRs
bedroge a3e5c31
only for pushes
bedroge d12c2dc
also for PRs
bedroge 9dc32ca
use correct dockerfile filename
bedroge 7811db6
Merge pull request #321 from bedroge/smee_client_container_image
trz42 6c599f4
Add package write permission to container build jon
bedroge d14a08e
Merge pull request #322 from EESSI/bedroge-patch-1
boegel 7f29d4d
make space before bot command optional
boegel a985803
Merge branch 'main' into git_clone_via_ssh
boegel 66005da
fix regex for bot build command + add log messages
boegel 02c2465
fix logging with regex pattern in get_bot_command
boegel 8eec372
mention function name in log message in get_bot_command
boegel 4b7c50c
Merge pull request #324 from EESSI/bot-command-optional-space
trz42 1381689
Merge branch 'develop' into git_clone_via_ssh
boegel 750b8a4
add pr_diff_failure and pr_diff_tip to required configuration settings
boegel 50c21d7
Merge pull request #300 from boegel/git_clone_via_ssh
trz42 fd31cd1
update prerequisites and section 1
truib 1a8211c
revise sections 2 and 3
truib 85cb96f
reformatting note
truib 9d422b2
add CI for markdown linting and fix all issues in README.md
truib a24ac74
layout tweaking
truib 47dd306
refine section 4
truib 29de868
improve sections 5.1 to 5.3
truib a015086
half way through revising app.cfg settings
truib 673c411
improved app.cfg section and cfg example file
truib 05786f3
apply suggestions from code review
trz42 e3041c7
addressing more suggested changes
truib baa16fe
Remove trailing white spaces
Neves-P 5065c16
Merge pull request #325 from trz42/update_readme_app_cfg_example
Neves-P dfbcec3
Merge branch 'EESSI:develop' into adapt_arch_target_map
casparvl b54fdf4
Fix xome small issues with non-existing keys
1e6c3d9
Avoid doing string += None for the arch_dir if accelerator = None. Al…
e000c91
Make sure that if the context (i.e. app.cfg) defines AN accelerator, …
40ceefe
Some cleanup
fad4f47
Remove repo_target_map from config, and all occurences that import it…
b4032a6
Fix quotation of keys
3898df7
Fix flake8 issue
ef0c430
Unpack the actual arch_target_map by accessing it with a key to get t…
e3df690
Fix mistake in build path
424a001
Parse on: and for: options, and pass the correct values on to the com…
3f00e51
Make sure that the for: arguments are used as build parameters
2625b30
Change path for job dir so that it represents the 'for' architectures
ffa2303
More extensive reporting by the bot on what to build for/on
c98e7e8
This is no longer needed, as it is done with the codecs (decode) now
5904f11
Print real arch_target_map keys when doing show_config
7c869f0
Reduce number of possible accelerators per node type to one. Nodes wi…
179ab0a
Fix app.cfg for the fact that partition_info['accel'] is now a string…
a9a2585
Make sure that we don't access a dict item that doesn't exist
51a9c74
Make sure a context match fails if the context doesn't provide e.g. a…
b12c911
Make old config items invalid, rename to node_type and note_type_map,…
697dc6e
Update the status command to account for the new on:... for:... syntax
c0fe051
Remove debugging print statements
f179b66
Warn about the removal of the repo_target_map
aad663e
Fix typo
be8c7d0
Fix hound issues
7f766f4
Format releveant output of show_config as code
d205598
Rephrase to make things more clear
ebcc7fd
Forgot to add this new file...
0a8bc9b
Fix hound issues
81257db
Update build params call signature
f974463
Fix example argument, and argument used to create build parameters in…
4104796
Forgot to actually git add this file again... anyway, updated the syn…
0b82386
Update the app.cfg used for the unit tests to account for the changes…
372a7fe
Update tests for new requirement that all filters have to be present …
d2be02a
Update tests to accomodate for new behaviour of filter checking that …
6b3a118
Fix hound issues
3b310f5
Fix flake8 issues
624109e
update the scontrol command to work on system with multiple clusters
laraPPr b14043e
clean up
laraPPr de0bd1c
Removed some comments that were only there for development, no longer…
d4ecc7b
Apply suggestions from code review
casparvl af731e1
Re-comment the awaits_release, as this was done in develop as well. T…
d48b355
Replace Partition with Node type in show_config output. Also, update …
6017433
Processed various smaller review comments for tasks/build.py. Elabora…
279e08f
Apply suggestions from code review
casparvl 80f5f1d
Fix indentation issue
2f3c0ae
Update tasks/build.py
casparvl 7a92892
Merge pull request #312 from casparvl/adapt_arch_target_map
bedroge 03e720d
add exception and simply using placeholder in scontrol command
laraPPr 54e502a
resolve merge conflict with upstream branch
laraPPr 53b032f
make stylecheck happy
laraPPr 519428f
some more error logging for the scontrol command
laraPPr e42b34e
Update readme for new node_type_map functionality
0b4e22f
Add examples of bot build commands
be7efe4
Process review comments
ae691e6
Fix linting errors
2ad48ec
Update README.md
casparvl 769150d
Update README.md
casparvl b4d86e0
Update README.md
casparvl 334fe8f
Merge pull request #329 from casparvl/update_readme_node_type_map
bedroge 9fb883b
Merge branch 'develop' into test_submit_to_all
laraPPr 72c39a4
simplify using placeholder for scontrol command
laraPPr 19c28f5
remove uneccesary change
laraPPr 9433bea
use rstrip in a list comprehension
laraPPr 09a4842
Update eessi_bot_job_manager.py
laraPPr a2e52dd
Update README
laraPPr 63fa9f3
Set a default self.build_params = None on constructiong the EESSIBotC…
4360e3d
Fix typo
1ad4640
WIP: trying to get a status command that only prints the last status …
7a55d30
Update README.md
laraPPr e349257
Update README.md
laraPPr 9a5bf4d
Add support for passing general arguments to a command, so that we ca…
583cacc
Fix typo
7c85854
Merge pull request #331 from casparvl/print_nice_error
boegel 16a4e0f
add description to app.cfg.example
laraPPr 6bfb246
Merge pull request #327 from laraPPr/test_submit_to_all
casparvl 25dd76d
Make sure that commands still function if no action filters were defi…
296942f
Fix some bugs. Also, make sure to actually use the sorted table when …
d335c3d
Fix too long lines
3fc6a6e
Don't define the lambda's separately
7b284ba
Merge branch 'develop' into print_last_status_only
casparvl fc3c23d
don't replace self.scontrol_command in process_new_job, to keep place…
boegel 0fdfed4
fix comment
boegel 5656a69
Merge pull request #335 from boegel/fix_templated_scontrol_command
laraPPr 2c5569b
Merge pull request #334 from casparvl/print_last_status_only
trz42 4b6d62a
release notes for v0.9.9
truib e0800eb
add missing information
truib 42d95ae
replacing more arch_target_map with node_type_map
truib 1e2697a
Merge pull request #337 from trz42/minor_tweaks_readme
boegel 45f0c10
Merge branch 'develop' of github.com:EESSI/eessi-bot-software-layer i…
truib fdc3b3a
add PR with additional fixes for README.md
truib c7e61aa
improvements/fixes taking review into account
truib 405fb2f
rephrase info about breaking changes
trz42 447a05c
date bump
truib d4d649c
remove duplicate information
truib 0e21338
Merge pull request #336 from trz42/release_notes_v0_9_0
boegel 1e70f3e
update upload-artifact version to 4.6.2
truib 05ead1d
also run scorecards when pushing/pull_requesting to develop branch
truib c6220fe
change action version 4.3.3
truib 7e197ae
also mention v0.9.0 release notes that initial_comment was replaced i…
boegel fc4d204
update version of codeql-action/upload-sarif to v3.25.6
truib fb2e1a0
Merge pull request #341 from boegel/rip_initial_comment
trz42 764c5c9
Merge pull request #340 from trz42/update_scorecards_CI
boegel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name: Build and publish a Smee client container image | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - containers/Dockerfile.smee-client | ||
| - .github/workflows/build_smee_client_container_image.yaml | ||
| pull_request: | ||
| paths: | ||
| - containers/Dockerfile.smee-client | ||
| - .github/workflows/build_smee_client_container_image.yaml | ||
|
|
||
| # Declare default permissions as read only. | ||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| docker_build_smee_client: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| packages: write | ||
| steps: | ||
| - name: Check out the repo | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Login to GitHub Container Registry | ||
| if: github.event_name != 'pull_request' | ||
| uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3.4.0 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Convert and store repository owner in lowercase, replace colon in tag names by hyphen | ||
| run: | | ||
| echo REPOSITORY_OWNER=$(echo ${{ github.repository_owner }} | tr '[:upper:]' '[:lower:]') >> $GITHUB_ENV | ||
|
|
||
| - name: Set up QEMU | ||
| uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392 # v3.6.0 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # v3.10.0 | ||
|
|
||
| - name: Cache Docker layers | ||
| uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3 | ||
| with: | ||
| path: ${{ runner.temp }}/.buildx-cache | ||
| key: ${{ runner.os }}-buildx-${{ github.sha }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-buildx- | ||
|
|
||
| - name: Build and push | ||
| uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0 | ||
| with: | ||
| tags: ghcr.io/${{ env.REPOSITORY_OWNER }}/smee-client | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: ${{ github.event_name != 'pull_request' }} # don't publish if this is part of an open PR | ||
| file: containers/Dockerfile.smee-client | ||
| cache-from: type=local,src=${{ runner.temp }}/.buildx-cache | ||
| cache-to: type=local,dest=${{ runner.temp }}/.buildx-cache-new,mode=max | ||
|
|
||
| - name: Move cache | ||
| run: | | ||
| rm -rf ${{ runner.temp }}/.buildx-cache | ||
| mv ${{ runner.temp }}/.buildx-cache-new ${{ runner.temp }}/.buildx-cache |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # This file is part of the EESSI build-and-deploy bot, | ||
| # see https://github.com/EESSI/eessi-bot-software-layer | ||
| # | ||
| # The bot helps with requests to add software installations to the | ||
| # EESSI software layer, see https://github.com/EESSI/software-layer | ||
| # | ||
| # author: Thomas Roeblitz (@trz42) | ||
| # | ||
| # license: GPLv2 | ||
| # | ||
|
|
||
| name: Markdown Lint | ||
| on: [push, pull_request] | ||
| # Declare default permissions as read only. | ||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| markdown-lint: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.0 | ||
| with: | ||
| node-version: '18' | ||
|
|
||
| - name: Install markdownlint-cli | ||
| run: npm install -g markdownlint-cli | ||
|
|
||
| - name: Run markdownlint | ||
| run: markdownlint "**/*.md" --ignore .git | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "default": true, | ||
| "MD013": false, | ||
| "MD033": false, | ||
| "MD041": false, | ||
| "MD024": false, | ||
| "MD026": { | ||
| "punctuation": ".,;:!" | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / Scorecard
Pinned-Dependencies Medium