Skip to content

Make sure that builds for different repos don't get deduplicated by the last_build option#345

Merged
bedroge merged 4 commits into
EESSI:developfrom
casparvl:dont_dedup_different_eessi_versions
Aug 28, 2025
Merged

Make sure that builds for different repos don't get deduplicated by the last_build option#345
bedroge merged 4 commits into
EESSI:developfrom
casparvl:dont_dedup_different_eessi_versions

Conversation

@casparvl
Copy link
Copy Markdown
Contributor

@casparvl casparvl commented Aug 26, 2025

Fixes #344

Note that I also added a self.log, to log the status table before we start modifying for the last_build option. Reason is that I was unable to reproduce #343 so the only chance we have at resolving that if it happens again is to have some better logging in place and see if we spot anything strange.

@casparvl casparvl marked this pull request as ready for review August 26, 2025 15:15
@casparvl
Copy link
Copy Markdown
Contributor Author

casparvl commented Aug 26, 2025

Fix is tested in casparvl/software-layer#4

A run from the current develop branch of the bot: casparvl/software-layer#4 (comment)
A run from the current feature branch for this PR: casparvl/software-layer#4 (comment)
A run from the current feature branch that shows that the last build is correctly taken if builds are identical (i.e. same 'for arch' and same 'repo'): casparvl/software-layer#4 (comment)

Seems like it does what it should be doing.

Comment thread eessi_bot_event_handler.py Outdated
@bedroge bedroge merged commit 45bb634 into EESSI:develop Aug 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bot:status last_build doesn't consider tarballs for different EESSI versions to be unique

2 participants