-
Notifications
You must be signed in to change notification settings - Fork 22
Improved parsing of scontrol output
#369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
92ca8a5
better parsing of scontrol output
bedroge f3b3fc0
update docstring
bedroge a57b3c1
add test for parse_scontrol_show_job_output
bedroge 70b8f8d
shorten paths/lines
bedroge c6523f5
split long line
bedroge 394677f
add explicit Slurm version to comment
bedroge b4777fa
rename i to idx
bedroge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could have constrained this a bit more by handing over a list of "expected" keys (and only return key-value pairs for those). While the new assumption may be correct now, we don't know if it will be in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did consider that, but I found this a bit more flexible, and it's now doing the exact same thing as before. They're using these kinds of names everywhere (in scontrol, sacct, sstat, etc), so I guess it's a rather safe assumption?
But I can easily change this if you want to, though it could still break in the future if they decide to change the structure/names.
Ah, you merged it while I was typing this, then I guess I'll leave it like this 😄