Skip to content

[gitlab] Improve test coverage #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sondrebr wants to merge 9 commits into
base: gitlab
Choose a base branch
from
Open

[gitlab] Improve test coverage #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6595fcd
Set `Gitlab` instance attributes on initialization
sondrebr Jun 22, 2026
1c39c0c
Add tests for connections/gitlab.py
sondrebr Jun 22, 2026
7a4313c
Add tests for tools/git.py
sondrebr Jun 22, 2026
6e97439
Add more tests for tools/commands.py
sondrebr Jun 22, 2026
c570c86
Add sample GitHub webhook events for use in tests
sondrebr Jun 22, 2026
3c8065f
Add sample GitLab webhook events for use in tests
sondrebr Jun 22, 2026
ce7334a
Fix GitLabEventInfo.label_name
sondrebr Jun 24, 2026
edf314e
Add tests for tools/event_info.py
sondrebr Jun 24, 2026
1782785
Fix hound issue
sondrebr Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions connections/gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ def connect():
else:
del os.environ['GITLAB_PROJECT_ACCESS_TOKEN']

_gl = gitlab.Gitlab(url, access_token)
_gl.timeout = timeout
_gl.retry_transient_errors = True
_gl = gitlab.Gitlab(url, access_token, timeout=timeout, retry_transient_errors=True)
verify_connection(_gl)


Expand Down
286 changes: 286 additions & 0 deletions test/events/github/comment-created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,286 @@
{
"headers": {
"Accept": "*/*",
"Accept-Encoding": "gzip, deflate",
"Accept-Language": "*",
"Connection": "keep-alive",
"Content-Length": "10707",
"Content-Type": "application/json",
"Host": "127.0.0.1:3000",
"Sec-Fetch-Mode": "cors",
"Timestamp": "1781521518638",
"User-Agent": "GitHub-Hookshot/831a06e",
"X-Forwarded-Scheme": "https",
"X-Github-Delivery": "17489dc0-68aa-11f1-8ed0-d59b5d8018bb",
"X-Github-Event": "issue_comment",
"X-Github-Hook-Id": "123454321",
"X-Github-Hook-Installation-Target-Id": "1234567",
"X-Github-Hook-Installation-Target-Type": "integration",
"X-Hub-Signature": "sha1=60cbee676aab387b71581fe44de1acf097698009",
"X-Hub-Signature-256": "sha256=d8e840eadfbd4e618b5b973fe724e85052e5ca9a8a4fdebe8c3614e74efd4402",
"X-Real-Ip": "140.82.115.100",
"X-Request-Id": "f19e7514808880ae7ef08dab43123b4a",
"X-Scheme": "https"
},
"json": {
"action": "created",
"comment": {
"author_association": "OWNER",
"body": "bot:help",
"created_at": "2026-06-15T11:05:16Z",
"html_url": "https://github.com/testuser/software-layer/pull/5#issuecomment-5432112345",
"id": 5432112345,
"issue_url": "https://api.github.com/repos/testuser/software-layer/issues/5",
"node_id": "IC_kwDOQngT988AAAABQ8d02Q",
"performed_via_github_app": null,
"reactions": {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/testuser/software-layer/issues/comments/5432112345/reactions"
},
"updated_at": "2026-06-15T11:05:16Z",
"url": "https://api.github.com/repos/testuser/software-layer/issues/comments/5432112345",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/123456789?v=4",
"events_url": "https://api.github.com/users/testuser/events{/privacy}",
"followers_url": "https://api.github.com/users/testuser/followers",
"following_url": "https://api.github.com/users/testuser/following{/other_user}",
"gists_url": "https://api.github.com/users/testuser/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/testuser",
"id": 123456789,
"login": "testuser",
"node_id": "U_kgDOB1vNFQ",
"organizations_url": "https://api.github.com/users/testuser/orgs",
"received_events_url": "https://api.github.com/users/testuser/received_events",
"repos_url": "https://api.github.com/users/testuser/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/testuser/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/testuser/subscriptions",
"type": "User",
"url": "https://api.github.com/users/testuser",
"user_view_type": "public"
}
},
"installation": {
"id": 99999999,
"node_id": "MDIzOkludGVncmF0aW9uSW5zdGFsbGF0aW9uOTk5OTk5OTk="
},
"issue": {
"active_lock_reason": null,
"assignee": null,
"assignees": [],
"author_association": "OWNER",
"body": "Test",
"closed_at": "2026-06-11T13:28:31Z",
"comments": 11,
"comments_url": "https://api.github.com/repos/testuser/software-layer/issues/5/comments",
"created_at": "2026-06-11T13:14:20Z",
"draft": false,
"events_url": "https://api.github.com/repos/testuser/software-layer/issues/5/events",
"html_url": "https://github.com/testuser/software-layer/pull/5",
"id": 9876543210,
"labels": [
{
"color": "87DA77",
"default": false,
"description": "",
"id": 1234554321,
"name": "test:label",
"node_id": "LA_kwDOQngT988AAAAASZXN0Q",
"url": "https://api.github.com/repos/testuser/software-layer/labels/test:label"
}
],
"labels_url": "https://api.github.com/repos/testuser/software-layer/issues/5/labels{/name}",
"locked": false,
"milestone": null,
"node_id": "PR_kwDOxmQDYCGSUsFF",
"number": 5,
"performed_via_github_app": null,
"pull_request": {
"diff_url": "https://github.com/testuser/software-layer/pull/5.diff",
"html_url": "https://github.com/testuser/software-layer/pull/5",
"merged_at": "2026-06-11T13:28:31Z",
"patch_url": "https://github.com/testuser/software-layer/pull/5.patch",
"url": "https://api.github.com/repos/testuser/software-layer/pulls/5"
},
"reactions": {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/testuser/software-layer/issues/5/reactions"
},
"repository_url": "https://api.github.com/repos/testuser/software-layer",
"state": "closed",
"state_reason": null,
"timeline_url": "https://api.github.com/repos/testuser/software-layer/issues/5/timeline",
"title": "Add software",
"updated_at": "2026-06-15T11:05:16Z",
"url": "https://api.github.com/repos/testuser/software-layer/issues/5",
"user": {
"avatar_url": "https://avatars.githubusercontent.com/u/123456789?v=4",
"events_url": "https://api.github.com/users/testuser/events{/privacy}",
"followers_url": "https://api.github.com/users/testuser/followers",
"following_url": "https://api.github.com/users/testuser/following{/other_user}",
"gists_url": "https://api.github.com/users/testuser/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/testuser",
"id": 123456789,
"login": "testuser",
"node_id": "U_kgDOB1vNFQ",
"organizations_url": "https://api.github.com/users/testuser/orgs",
"received_events_url": "https://api.github.com/users/testuser/received_events",
"repos_url": "https://api.github.com/users/testuser/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/testuser/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/testuser/subscriptions",
"type": "User",
"url": "https://api.github.com/users/testuser",
"user_view_type": "public"
}
},
"repository": {
"allow_forking": true,
"archive_url": "https://api.github.com/repos/testuser/software-layer/{archive_format}{/ref}",
"archived": false,
"assignees_url": "https://api.github.com/repos/testuser/software-layer/assignees{/user}",
"blobs_url": "https://api.github.com/repos/testuser/software-layer/git/blobs{/sha}",
"branches_url": "https://api.github.com/repos/testuser/software-layer/branches{/branch}",
"clone_url": "https://github.com/testuser/software-layer.git",
"collaborators_url": "https://api.github.com/repos/testuser/software-layer/collaborators{/collaborator}",
"comments_url": "https://api.github.com/repos/testuser/software-layer/comments{/number}",
"commits_url": "https://api.github.com/repos/testuser/software-layer/commits{/sha}",
"compare_url": "https://api.github.com/repos/testuser/software-layer/compare/{base}...{head}",
"contents_url": "https://api.github.com/repos/testuser/software-layer/contents/{+path}",
"contributors_url": "https://api.github.com/repos/testuser/software-layer/contributors",
"created_at": "2025-12-12T12:44:16Z",
"default_branch": "main",
"deployments_url": "https://api.github.com/repos/testuser/software-layer/deployments",
"description": "Software layer of the EESSI project",
"disabled": false,
"downloads_url": "https://api.github.com/repos/testuser/software-layer/downloads",
"events_url": "https://api.github.com/repos/testuser/software-layer/events",
"fork": true,
"forks": 0,
"forks_count": 0,
"forks_url": "https://api.github.com/repos/testuser/software-layer/forks",
"full_name": "testuser/software-layer",
"git_commits_url": "https://api.github.com/repos/testuser/software-layer/git/commits{/sha}",
"git_refs_url": "https://api.github.com/repos/testuser/software-layer/git/refs{/sha}",
"git_tags_url": "https://api.github.com/repos/testuser/software-layer/git/tags{/sha}",
"git_url": "git://github.com/testuser/software-layer.git",
"has_discussions": false,
"has_downloads": true,
"has_issues": true,
"has_pages": false,
"has_projects": true,
"has_pull_requests": true,
"has_wiki": true,
"homepage": "https://eessi.github.io/docs/software_layer",
"hooks_url": "https://api.github.com/repos/testuser/software-layer/hooks",
"html_url": "https://github.com/testuser/software-layer",
"id": 1234567890,
"is_template": false,
"issue_comment_url": "https://api.github.com/repos/testuser/software-layer/issues/comments{/number}",
"issue_events_url": "https://api.github.com/repos/testuser/software-layer/issues/events{/number}",
"issues_url": "https://api.github.com/repos/testuser/software-layer/issues{/number}",
"keys_url": "https://api.github.com/repos/testuser/software-layer/keys{/key_id}",
"labels_url": "https://api.github.com/repos/testuser/software-layer/labels{/name}",
"language": "Python",
"languages_url": "https://api.github.com/repos/testuser/software-layer/languages",
"license": {
"key": "gpl-2.0",
"name": "GNU General Public License v2.0",
"node_id": "MDc6TGljZW5zZTg=",
"spdx_id": "GPL-2.0",
"url": "https://api.github.com/licenses/gpl-2.0"
},
"merges_url": "https://api.github.com/repos/testuser/software-layer/merges",
"milestones_url": "https://api.github.com/repos/testuser/software-layer/milestones{/number}",
"mirror_url": null,
"name": "software-layer",
"node_id": "R_kgDOSZYC0g",
"notifications_url": "https://api.github.com/repos/testuser/software-layer/notifications{?since,all,participating}",
"open_issues": 2,
"open_issues_count": 2,
"owner": {
"avatar_url": "https://avatars.githubusercontent.com/u/123456789?v=4",
"events_url": "https://api.github.com/users/testuser/events{/privacy}",
"followers_url": "https://api.github.com/users/testuser/followers",
"following_url": "https://api.github.com/users/testuser/following{/other_user}",
"gists_url": "https://api.github.com/users/testuser/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/testuser",
"id": 123456789,
"login": "testuser",
"node_id": "U_kgDOB1vNFQ",
"organizations_url": "https://api.github.com/users/testuser/orgs",
"received_events_url": "https://api.github.com/users/testuser/received_events",
"repos_url": "https://api.github.com/users/testuser/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/testuser/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/testuser/subscriptions",
"type": "User",
"url": "https://api.github.com/users/testuser",
"user_view_type": "public"
},
"private": false,
"pull_request_creation_policy": "all",
"pulls_url": "https://api.github.com/repos/testuser/software-layer/pulls{/number}",
"pushed_at": "2026-06-11T13:28:31Z",
"releases_url": "https://api.github.com/repos/testuser/software-layer/releases{/id}",
"size": 4528,
"ssh_url": "git@github.com:testuser/software-layer.git",
"stargazers_count": 0,
"stargazers_url": "https://api.github.com/repos/testuser/software-layer/stargazers",
"statuses_url": "https://api.github.com/repos/testuser/software-layer/statuses/{sha}",
"subscribers_url": "https://api.github.com/repos/testuser/software-layer/subscribers",
"subscription_url": "https://api.github.com/repos/testuser/software-layer/subscription",
"svn_url": "https://github.com/testuser/software-layer",
"tags_url": "https://api.github.com/repos/testuser/software-layer/tags",
"teams_url": "https://api.github.com/repos/testuser/software-layer/teams",
"topics": [],
"trees_url": "https://api.github.com/repos/testuser/software-layer/git/trees{/sha}",
"updated_at": "2026-06-11T13:34:25Z",
"url": "https://api.github.com/repos/testuser/software-layer",
"visibility": "public",
"watchers": 0,
"watchers_count": 0,
"web_commit_signoff_required": false
},
"sender": {
"avatar_url": "https://avatars.githubusercontent.com/u/123456789?v=4",
"events_url": "https://api.github.com/users/testuser/events{/privacy}",
"followers_url": "https://api.github.com/users/testuser/followers",
"following_url": "https://api.github.com/users/testuser/following{/other_user}",
"gists_url": "https://api.github.com/users/testuser/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/testuser",
"id": 123456789,
"login": "testuser",
"node_id": "U_kgDOB1vNFQ",
"organizations_url": "https://api.github.com/users/testuser/orgs",
"received_events_url": "https://api.github.com/users/testuser/received_events",
"repos_url": "https://api.github.com/users/testuser/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/testuser/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/testuser/subscriptions",
"type": "User",
"url": "https://api.github.com/users/testuser",
"user_view_type": "public"
}
}
}
Loading
Loading