Support dash init shell with Lmod approach, make sure second initialsation gives expected EESSI version#182
Merged
casparvl merged 10 commits intoEESSI:mainfrom Mar 24, 2026
Merged
Conversation
…sation gives expected EESSI version
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
Contributor
|
Does our CI cover all these shells? |
Member
Author
No, but they are to Ubuntu and in Lmod init dir it is called
Yes |
ocaisa
commented
Mar 19, 2026
| . assert.sh/assert.sh | ||
|
|
||
| TEST_SHELLS=("bash" "zsh" "fish" "ksh" "csh") | ||
| TEST_SHELLS=("bash" "zsh" "fish" "ksh" "csh" "sh") |
Member
Author
There was a problem hiding this comment.
@boegel All shells are covered via this script
ocaisa
commented
Mar 19, 2026
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| #!/usr/bin/env sh | |||
Member
Author
There was a problem hiding this comment.
This script is meant to be sourced, so the shebang here is meaningless
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
ocaisa
commented
Mar 19, 2026
Co-authored-by: ocaisa <alan.ocais@cecam.org>
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
casparvl
reviewed
Mar 24, 2026
casparvl
requested changes
Mar 24, 2026
Contributor
casparvl
left a comment
casparvl
left a comment
There was a problem hiding this comment.
I think it's confusing that the actual POSIX compliant script is now init/lmod/bash. I'd say init/lmod/sh should be the POSIX compliant script, and all POSIX compliant shells (bash/ksh/zsh) should symlink to that. Keeping the actual script in init/lmod/bash is confusing, since someone may add bash syntax later (the only thing telling them not to is the shebang - but you can see how it may be confusing if the script is called bash). If it's init/lmod/sh, it is immediately clear that this is POSIX compliant and shouldn't contain any shell-specific syntax.
Member
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-deucalion for:arch=aarch64/a64fx |
|
New job on instance
|
|
New job on instance
|
casparvl
approved these changes
Mar 24, 2026
Contributor
|
CI checks aren't checking if these scripts are up-to-date, so I might as well merge this right now - even though the S0 is actually still ingesting things... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make BASH, ZSH, KSH posix compliant so they just be symlinks (and we can then support
dash)Fixes #178