add hook to avoid requiring ncurses static libraries for CMake built with system toolchain#81
Conversation
|
|
||
| if self.name == 'CMake': | ||
| if self.toolchain.name == 'system': | ||
| print_msg("Unset configopts to use ncurses library from the EESSI compatibility layer") |
There was a problem hiding this comment.
Use self.log.info here, or print_msg with log=self.log if you want to be very verbose about this.
I would also log what the previous value of configopts was, so it's clear what's being wiped.
There was a problem hiding this comment.
@boegel I have updated the log messages as suggested
… with system compiler
only remove `-DCURSES_.*_LIBRARY` configure options when building CMake…
boegel
left a comment
There was a problem hiding this comment.
lgtm, tested to verify that it works as intended
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
staging PR merged... |
|
@boegel we should also build and deploy this for 2025.06? |
Yes, exactly. ❤️ CI |
|
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
staging PR for 2025.06 merged |
system toolchain
this hook fixes issue EESSI/software-layer#1175
now I can build cmake on top of EESSI but I noticed something weird. I don't know why
configoptsare not completely removed. This is the original easyconfig:but when building with this hook I see this (notice the
--after--parallel=16I am also not sure if I should use
print_msg()or something different likelog.infoorlog.debug