Skip to content

Commit 556e9b4

Browse files
authored
Merge pull request #778 from casparvl/define_site_installpath
Rebuild `EESSI-extend` to use `EESSI_SITE_SOFTWARE_PATH`
2 parents e8686fb + 9f7982d commit 556e9b4

5 files changed

Lines changed: 19 additions & 9 deletions

File tree

.github/workflows/tests_eessi_module.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,15 @@ jobs:
7272
module load EESSI/${{matrix.EESSI_VERSION}}
7373
env | grep -E '^(EESSI_S|EESSI_C)' | sort > "${moduleoutfile}"
7474
module unload EESSI/${{matrix.EESSI_VERSION}}
75-
source /cvmfs/software.eessi.io/versions/${{matrix.EESSI_VERSION}}/init/bash
75+
source ./init/bash
7676
env | grep -E '^(EESSI_S|EESSI_C)' | sort > "${sourceoutfile}"
7777
cat "${moduleoutfile}"
7878
cat "${sourceoutfile}"
7979
if (diff "${moduleoutfile}" "${sourceoutfile}" > /dev/null); then
8080
echo "Test for checking env variables PASSED"
8181
else
8282
echo "Test for checking env variables FAILED" >&2
83+
diff "${moduleoutfile}" "${sourceoutfile}"
8384
exit 1
8485
fi
8586

EESSI-extend-2023.06-easybuild.eb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ elseif (os.getenv("EESSI_SITE_INSTALL") ~= nil) then
9292
if ((os.getenv("EESSI_PROJECT_INSTALL") ~= nil) or (os.getenv("EESSI_USER_INSTALL") ~= nil)) then
9393
LmodError("You cannot use EESSI_SITE_INSTALL in combination with any other EESSI_*_INSTALL environment variables")
9494
end
95-
easybuild_installpath = string.gsub(os.getenv("EESSI_SOFTWARE_PATH"), 'versions', 'host_injections')
95+
easybuild_installpath = os.getenv("EESSI_SITE_SOFTWARE_PATH")
9696
else
9797
-- Deal with user and project installs
9898
project_install = os.getenv("EESSI_PROJECT_INSTALL")
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# 2024.10.08
2+
# EESSI-extend should use EESSI_SITE_INSTALLPATH, instead of recalculating this
3+
easyconfigs:
4+
- EESSI-extend-2023.06-easybuild.eb
5+

init/eessi_environment_variables

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,15 +120,17 @@ if [ -d $EESSI_PREFIX ]; then
120120
if [ ! -z $EESSI_BASIC_ENV ]; then
121121
show_msg "Only setting up basic environment, so we're done"
122122
elif [ -d $EESSI_SOFTWARE_PATH ]; then
123+
export EESSI_SITE_SOFTWARE_PATH=${EESSI_SOFTWARE_PATH/versions/host_injections}
124+
show_msg "Using ${EESSI_SITE_SOFTWARE_PATH} as the site extension directory for installations."
125+
# Allow for use of alternative module tree shipped with EESSI
126+
if [ -z ${EESSI_MODULE_SUBDIR+x} ]; then
127+
# EESSI_MODULE_SUBDIR not set
128+
EESSI_MODULE_SUBDIR="modules/all"
129+
fi
123130
# Allow for the use of a custom MNS
124131
if [ -z ${EESSI_CUSTOM_MODULEPATH+x} ]; then
125132
# EESSI_CUSTOM_MODULEPATH not set so we use our defaults
126133

127-
# Allow for use of alternative module tree shipped with EESSI
128-
if [ -z ${EESSI_MODULE_SUBDIR+x} ]; then
129-
# EESSI_MODULE_SUBDIR not set
130-
EESSI_MODULE_SUBDIR="modules/all"
131-
fi
132134
EESSI_MODULEPATH=$EESSI_SOFTWARE_PATH/$EESSI_MODULE_SUBDIR
133135
else
134136
show_msg "Using defined environment variable \$EESSI_CUSTOM_MODULEPATH to set EESSI_MODULEPATH."
@@ -138,7 +140,7 @@ if [ -d $EESSI_PREFIX ]; then
138140
if [ -d $EESSI_MODULEPATH ]; then
139141
export EESSI_MODULEPATH=$EESSI_MODULEPATH
140142
show_msg "Using ${EESSI_MODULEPATH} as the directory to be added to MODULEPATH."
141-
export EESSI_SITE_MODULEPATH=${EESSI_MODULEPATH/versions/host_injections}
143+
export EESSI_SITE_MODULEPATH=$EESSI_SITE_SOFTWARE_PATH/$EESSI_MODULE_SUBDIR
142144
show_msg "Using ${EESSI_SITE_MODULEPATH} as the site extension directory to be added to MODULEPATH."
143145
else
144146
error "EESSI module path at $EESSI_MODULEPATH not found!"

init/modules/EESSI/2023.06.lua

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,11 @@ local eessi_software_subdir = archdetect
4848
local eessi_eprefix = pathJoin(eessi_prefix, "compat", eessi_os_type, eessi_cpu_family)
4949
local eessi_software_path = pathJoin(eessi_prefix, "software", eessi_os_type, eessi_software_subdir)
5050
local eessi_module_path = pathJoin(eessi_software_path, "modules", "all")
51-
local eessi_site_module_path = string.gsub(eessi_module_path, "versions", "host_injections")
51+
local eessi_site_software_path = string.gsub(eessi_software_path, "versions", "host_injections")
52+
local eessi_site_module_path = pathJoin(eessi_site_software_path, "modules", "all")
5253
setenv("EPREFIX", eessi_eprefix)
5354
setenv("EESSI_CPU_FAMILY", eessi_cpu_family)
55+
setenv("EESSI_SITE_SOFTWARE_PATH", eessi_site_software_path)
5456
setenv("EESSI_SITE_MODULEPATH", eessi_site_module_path)
5557
setenv("EESSI_SOFTWARE_SUBDIR", eessi_software_subdir)
5658
setenv("EESSI_PREFIX", eessi_prefix)

0 commit comments

Comments
 (0)