Feat/separate world shape#336
Open
sjcl wants to merge 5 commits into
Open
Conversation
sjcl
requested review from
Siro256 and
yanorei32
and removed request for
yanorei32
July 18, 2026 12:08
Rendering Resultsdemo_quake_prefecture_v0_base65536.webp
demo_quake_prefecture_v0_base32768.webp
demo_tsunami_forecast_v0_base32768.webp
demo_tsunami_forecast_v1_base32768.webp
|
yanorei32
reviewed
Jul 19, 2026
| clear_color[3], | ||
| ); | ||
|
|
||
| let map_layers = request_frame_context.payload.map_layers(); |
Member
There was a problem hiding this comment.
本当にここであるべきかについて考えています。
traitで切り出したほうがきれい…？いやそんなことはないか。うーん謎。
まぁ妥当な気もしてきた。
yanorei32
reviewed
Jul 19, 2026
Rendering Resultsdemo_quake_prefecture_v0_base65536.webp
demo_quake_prefecture_v0_base32768.webp
demo_tsunami_forecast_v0_base32768.webp
demo_tsunami_forecast_v1_base32768.webp
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257, Closes #324