Skip to content

fix: load skills from external_dirs in WebUI skills page#927

Open
529349029 wants to merge 1 commit into
EKKOLearnAI:mainfrom
529349029:fix/skills-load-external-dirs
Open

fix: load skills from external_dirs in WebUI skills page#927
529349029 wants to merge 1 commit into
EKKOLearnAI:mainfrom
529349029:fix/skills-load-external-dirs

Conversation

@529349029
Copy link
Copy Markdown

Problem

The WebUI skills page (/skills) only scans ~/.hermes/skills/ for skills, completely ignoring skills.external_dirs from config.yaml. Skills in external directories (e.g., ~/commonSkills/) are invisible in the UI.

Fix

  • getAllSkillsDirs(): reads skills.external_dirs from config and expands ~ to home directory
  • list(): scans all directories, merges categories, deduplicates skills by name
  • listFiles(): searches all directories for skill files
  • readFile_(): searches all directories when reading skill content, with path traversal protection per directory

Testing

  • Skills from ~/.hermes/skills/ still load as before
  • Skills from external dirs now appear in the listing
  • Duplicate skill names from different sources are merged (first source wins)
  • Error handling: missing/denied directories are silently skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant