Skip to content

Add Bluesky topnav feature; and update name of X (formerly Twitter)#325

Closed
PhilReedData wants to merge 3 commits into
ELIXIR-Belgium:mainfrom
PhilReedData:main
Closed

Add Bluesky topnav feature; and update name of X (formerly Twitter)#325
PhilReedData wants to merge 3 commits into
ELIXIR-Belgium:mainfrom
PhilReedData:main

Conversation

@PhilReedData
Copy link
Copy Markdown
Contributor

From issues #321, copying the Twitter topnav code to include Bluesky as another choice. Uses the Font Awesome logo again. Docs page also updated.

Tested in FAIRDOM website FAIRdom/fairdom.github.io#131
image
image
Here it uses my remote fork https://github.com/PhilReedData/elixir-toolkit-theme/releases/tag/bluesky-002 and shows both Twitter and Bluesky.

I updated the name of Twitter to 'X (formerly Twitter)' which I have seen on many sites, though they tend to be dropping the word 'Twitter' now too. It looks a little odd, showing an X logo then just an X text, if we were to drop the 'formerly Twitter' bit too, though I think that's on Elon Musk to blame. I don't mind if you drop this part of my PR and just add Bluesky.

@bedroesb
Copy link
Copy Markdown
Member

bedroesb commented Feb 7, 2025

@PhilReedData I think your somebody was first to add this #324 . I am not a fan of the formerly twitter thing and I am thinking of dropping the text all together, see the other linked PR.

Do you think we can work further on it in the other PR and I close this one?

@PhilReedData
Copy link
Copy Markdown
Contributor Author

Sure, yes close this PR, perhaps use my documentation edit to inspire work in that one.

@bedroesb
Copy link
Copy Markdown
Member

bedroesb commented Feb 7, 2025

@PhilReedData Like always, I am thankful for your contributions. Hope the linked PR in the issue will not go unnoticed next time :) Have a nice weekend.

@bedroesb bedroesb closed this Feb 7, 2025
@anenadic
Copy link
Copy Markdown
Contributor

@PhilReedData I think your somebody was first to add this #324 . I am not a fan of the formerly twitter thing and I am thinking of dropping the text all together, see the other linked PR.

That was me 😆 @PhilReedData - I independently noticed the same issue and came to fix it as we needed it for RSQKit too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants