Skip to content

Skip CD release workflow for bot commits #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CasperWA wants to merge 4 commits into from
Closed

Skip CD release workflow for bot commits #722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a58197f
Replace push-protected with direct push via TEAM4-0 bypass
CasperWA Apr 21, 2026
ff63436
Use RELEASE_PAT for checkout to ensure push authenticates as TEAM4-0
CasperWA Apr 21, 2026
68904ae
Remove dead push-action/** trigger from ci_tests.yml
CasperWA Apr 21, 2026
a437b6d
Skip CD release workflow for bot commits
CasperWA Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/workflows/cd_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
update_version:
name: Update the version
if: github.repository_owner == 'EMMC-ASBL'
if: github.repository_owner == 'EMMC-ASBL' && !startsWith(github.event.head_commit.message, '[bot]')
runs-on: ubuntu-latest
outputs:
continue_workflow: ${{ steps.update_version_step.outputs.continue_workflow }}
Expand All @@ -27,6 +27,7 @@ jobs:
uses: actions/checkout@v6
with:
fetch-depth: 0
token: ${{ secrets.RELEASE_PAT }}

- name: Set up git config
run: |
Expand Down Expand Up @@ -74,13 +75,7 @@ jobs:

- name: Update '${{ env.DEFAULT_REPO_BRANCH }}'
if: steps.update_version_step.outputs.continue_workflow == 'true'
uses: CasperWA/push-protected@v2
with:
token: ${{ secrets.RELEASE_PAT }}
branch: ${{ env.DEFAULT_REPO_BRANCH }}
pre_sleep: 15
force: false
unprotect_reviews: true
run: git push origin ${{ env.DEFAULT_REPO_BRANCH }}

Copilot AI Apr 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing CasperWA/push-protected@v2 with a plain git push will fail if master is protected (the workflow previously used push-protected with unprotect_reviews: true, which strongly suggests branch protection is in place). Either keep using push-protected, or confirm/update the branch protection rules to allow this workflow’s actor/token (RELEASE_PAT / GitHub Actions) to push directly to master (e.g., allow bypass or allow the PAT user to push).

Suggested change
run: git push origin ${{ env.DEFAULT_REPO_BRANCH }}
uses: CasperWA/push-protected@v2
with:
token: ${{ secrets.RELEASE_PAT }}
branch: ${{ env.DEFAULT_REPO_BRANCH }}
unprotect_reviews: true

Copilot uses AI. Check for mistakes.

publish_container_image:
name: Publish Container image on GH Packages
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:
push:
branches:
- 'master'
- 'push-action/**' # Allow pushing to protected branches (using CasperWA/push-protected)

Comment on lines 5 to 8

Copilot AI Apr 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the push-action/** branch trigger from the CI tests workflow, but the PR description only mentions the CD infinite-loop fix. If any automation still pushes temporary branches matching push-action/** (e.g., protected-branch push helpers), CI coverage for those pushes will stop. Either document this change in the PR description or keep the trigger if those branches are still used anywhere.

Copilot uses AI. Check for mistakes.
jobs:
pre-commit_audit:
Expand Down