Skip to content

Commit a12e23c

Browse files
committed
Merge branch 'di_workflow_bjm' into 'LC_FTICR_Final'
Direct Infusion workflow updates and improvements See merge request mass-spectrometry/enviroms!10
2 parents 489a293 + 973bef7 commit a12e23c

21 files changed

Lines changed: 426 additions & 921 deletions

.gitignore

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,9 @@ share/python-wheels/
3939
*.egg
4040

4141
# Raw data files
42-
*.raw
42+
*.raw
43+
*.d
44+
data/raw_data/example_data/
45+
46+
# Processed data
47+
output

Makefile

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@ docker-build:
7272

7373
docker-build-local:
7474

75-
docker build -t local-enviroms:$(version) .
76-
75+
docker build --pull --no-cache -t local-enviroms:latest .
7776

7877
docker-run-di:
7978

@@ -91,14 +90,25 @@ cascade-run:
9190

9291
srun -A mscms -t 240 -N 1 -n time enviroMS run-di -r 2 --mpi /dtemp/mscms/enviroms/data/configuration/enviroms.toml
9392

93+
cli-run-di :
94+
enviroMS run_di configuration/di_enviroms.toml --jobs 1 --replicas 1 --tasks 1
95+
9496
wdl-run-di :
9597

9698
miniwdl run wdl/di_fticr_ms.wdl -i wdl/di_fticr_wdl_input.json --verbose --no-cache --copy-input-files
9799

100+
wdl-run-di-local :
101+
@make docker-build-local
102+
miniwdl run wdl/di_fticr_ms.wdl -i wdl/di_fticr_wdl_input_local_docker.json --verbose --no-cache --copy-input-files
103+
98104
wdl-run-lc :
99105

100106
miniwdl run wdl/lc_fticr_ms.wdl -i wdl/lc_fticr_wdl_input.json --verbose --no-cache --copy-input-files
101107

108+
wdl-run-lc-local:
109+
110+
miniwdl run wdl/lc_fticr_ms.wdl -i wdl/lc_fticr_wdl_input_local_docker.json --verbose --no-cache --copy-input-files
111+
102112
get-lcms-fticr-test-data:
103113

104114
@echo "Downloading test files for LC-MS FT-ICR workflow"
@@ -132,6 +142,4 @@ get-lcms-fticr-test-data:
132142
else echo "Reference file exists"; fi
133143
@echo "LC-MS FT-ICR test files complete"
134144

135-
wdl-run-lc-local:
136145

137-
miniwdl run wdl/lc_fticr_ms.wdl -i wdl/lc_fticr_wdl_input_local_docker.json --verbose --no-cache --copy-input-files

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ A docker image containing the EnviroMS command line as code entry-point
199199
- Run Workflow from Container:
200200
201201
$(data_dir) = dir_containing the FT-ICR MS data
202-
$(configuration_dir) = dir_containing the enviroms.toml, corems.toml and nmdc_metadata.json
202+
$(configuration_dir) = dir_containing the enviroms.toml and corems.toml
203203
204204
```bash
205205
docker run -v $(data_dir):/enviroms/data \

configuration/di_corems.toml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ isotopologue_filter_atoms = [ "Cl", "Br",]
55
use_runtime_kendrick_filter = false
66
use_min_peaks_filter = true
77
min_peaks_per_class = 15
8-
url_database = "sqlite:///db/molformulas.db"
8+
url_database = ""
99
db_jobs = 3
1010
db_chunk_size = 300
1111
ion_charge = -1
@@ -77,14 +77,17 @@ implemented_kendrick_rounding_methods = [ "floor", "ceil", "round",]
7777
peak_derivative_threshold = 0.0
7878
peak_min_prominence_percent = 0.1
7979
min_peak_datapoints = 5.0
80-
peak_max_prominence_percent = 0.1
80+
peak_max_prominence_percent = 1
8181
peak_height_max_percent = 10.0
8282
legacy_resolving_power = true
8383
centroid_legacy_polyfit = false
8484

8585
[MolecularFormulaSearch.usedAtoms]
8686
C = [ 1, 100,]
87-
H = [ 1, 200,]
87+
H = [ 4, 200,]
88+
O = [ 0, 22,]
89+
N = [ 0, 1,]
90+
S = [ 0, 1,]
8891

8992
[MolecularFormulaSearch.used_atom_valences]
9093
C = 4

configuration/di_enviroms.toml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
raw_file_start_scan = 1
22
raw_file_final_scan = 7
3-
file_paths = [ "data/raw_data/20190709_WK_CADY_Auto_S16_H1_Post_O5_1_01_36.tsv" ]
3+
file_paths = ["data/raw_data/NEG_ESI_SRFA_Auto.d", "data/raw_data/SRFA_40ppm_NegativeESI_21T.raw"]
44
output_directory = "output"
55
output_group_name = "..."
66
output_type = "csv"
77
polarity = -1
88
is_centroid = true
9-
corems_toml_path = "configuration/corems.toml"
10-
nmdc_metadata_path = "configuration/nmdc_metadata.json"
9+
corems_toml_path = "configuration/di_corems.toml"
1110
calibrate = true
12-
calibration_ref_file_path = "data/raw_data/SRFA.ref"
11+
batch_calibrate = true
12+
calibration_ref_file_path = "./data/reference/Hawkes_neg.ref"
1313
plot_mz_error = true
1414
plot_ms_assigned_unassigned = true
1515
plot_c_dbe = true
1616
plot_van_krevelen = true
1717
plot_ms_classes = true
18-
plot_mz_error_classes = true
18+
plot_mz_error_classes = true
19+
plot_qc = true

configuration/nmdc_metadata.json

Lines changed: 0 additions & 108 deletions
This file was deleted.

data/sample_processing/samp_proc_instantiation.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

data/sample_processing/sample_process_gcms.json

Lines changed: 0 additions & 108 deletions
This file was deleted.

0 commit comments

Comments
 (0)