Skip to content

Commit 6268256

Browse files
committed
Simplify github action for downloading test data
1 parent 4e4fac2 commit 6268256

2 files changed

Lines changed: 8 additions & 23 deletions

File tree

.github/workflows/workflow_tests.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,20 +28,16 @@ jobs:
2828
python -m pip install --upgrade pip
2929
pip install miniwdl
3030
31-
- name: Download LCMS metabolomics database
31+
- name: Download LCMS metabolomics database and test data
3232
run: |
33-
make get-lcms-database
34-
35-
- name: Download lipidomics test data
36-
run: |
37-
make get-lipid-test-data
38-
39-
- name: Run Lipidomics WDL with lipidomics test data
33+
make get-test-data
34+
35+
- name: Run Lipidomics WDL with lipidomics test data and pushed Docker Image
4036
run: |
4137
miniwdl run wdl/metaMS_lcmslipidomics.wdl -i wdl/metams_input_lipidomics.json --verbose --no-cache --copy-input-files
4238
4339
# This will fail until the new Docker image is pushed to Docker Hub
44-
#- name: Run LCMS metabolomics WDL with LCMS metabolomics test data
40+
#- name: Run LCMS metabolomics WDL with test data and pushed Docker Image
4541
# run: |
4642
# make wdl-run-lcms-metab
4743

Makefile

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -141,20 +141,9 @@ wdl-run-lipid-local:
141141
@make docker-build-local
142142
miniwdl run wdl/metaMS_lcmslipidomics.wdl -i wdl/metams_input_lipidomics_local_docker.json --verbose --no-cache --copy-input-files
143143

144-
get-lcms-metab-test-data:
145-
@echo "Downloading test data for LC-MS metabolomics workflow"
146-
@mkdir -p test_data
147-
@curl --retry 3 --retry-delay 5 --connect-timeout 30 --max-time 300 -L -o test_data/test_lcms_metab_data.zip https://nmdcdemo.emsl.pnl.gov/metabolomics/test_data/metams_lcms_metab_test_data/test_lcms_metab_data.zip
148-
@unzip test_data/test_lcms_metab_data.zip -d test_data/
149-
@rm test_data/test_lcms_metab_data.zip
150-
@echo "Test data downloaded and unzipped"
151-
152-
get-test-data: get-lipid-test-data wait-and-get-lcms-metab-test-data
153-
154-
wait-and-get-lcms-metab-test-data:
155-
@echo "Waiting 30 seconds before downloading LC-MS metabolomics data..."
156-
@sleep 30
157-
@$(MAKE) get-lcms-metab-test-data
144+
get-test-data:
145+
@make get-lipid-test-data
146+
@make get-lcms-database
158147

159148
wdl-run-lcms-metab :
160149
miniwdl run wdl/metaMS_lcms_metabolomics.wdl -i wdl/metams_input_lcms_metabolomics.json --verbose --no-cache --copy-input-files

0 commit comments

Comments
 (0)