Skip to content

Commit ea47018

Browse files
committed
Reconfigure lcms metab test data makefile commands
1 parent 2b0065f commit ea47018

4 files changed

Lines changed: 19 additions & 8 deletions

File tree

.github/workflows/workflow_tests.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,13 @@ jobs:
2828
python -m pip install --upgrade pip
2929
pip install miniwdl
3030
31-
- name: Download LCMS metabolomics test data
31+
- name: Download LCMS metabolomics database
3232
run: |
33-
make get-lcms-metab-test-data
33+
make get-lcms-database
34+
35+
- name: Download lipidomics test data
36+
run: |
37+
make get-lipid-test-data
3438
3539
- name: Run Lipidomics WDL with lipidomics test data
3640
run: |

Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,12 @@ wdl-run-gcms-local:
119119
@make docker-build-local
120120
@miniwdl run wdl/metaMS_gcms.wdl -i wdl/metams_input_gcms_local_docker.json --verbose --no-cache --copy-input-files
121121

122+
get-lcms-database:
123+
@echo "Downloading LC-MS database"
124+
@mkdir -p test_data/test_lcms_metab_data
125+
@curl --retry 3 --retry-delay 5 --connect-timeout 30 --max-time 300 -L -o test_data/test_lcms_metab_data/database.msp https://nmdcdemo.emsl.pnnl.gov/metabolomics/databases/20250407_gnps_curated.msp
126+
@echo "LC-MS database downloaded"
127+
122128
get-lipid-test-data:
123129
@echo "Downloading test data for lipidomics"
124130
@mkdir -p test_data

metaMS/lcms_metabolomics_workflow.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ def process_complete_workflow(args):
363363

364364
# MS2 processing and export
365365
process_ms2(lcms_obj, metadata, scan_translator)
366-
export_results(lcms_obj, output_path, metadata["molecular_metadata"], final=True)
366+
export_results(lcms_obj, str(output_path), metadata["molecular_metadata"], final=True)
367367

368368
return f"Completed: {output_path}"
369369
except Exception as e:
@@ -446,6 +446,7 @@ def run_lcms_metabolomics_workflow(
446446
if cores == 1 or len(files_list) == 1:
447447
for file_in, output_path in zip(files_list, out_paths_list):
448448
args = (file_in, output_path, params_toml, scan_translator, metadata)
449+
process_complete_workflow(args)
449450

450451
elif cores > 1:
451452
with Pool(cores) as pool:
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
22
"lcmsMetabolomics.docker_image": "local-metams:latest",
33
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.file_paths": [
4-
"./test_data/test_lcms_metab_data/Blanch_Nat_Lip_C_4_AB_M_08_NEG_25Jan18_Brandi-WCSH5801.raw",
5-
"./test_data/test_lcms_metab_data/Blanch_Nat_Lip_C_4_AB_M_08_POS_23Jan18_Brandi-WCSH5801.raw"
4+
"./test_data/test_lipid_data/Blanch_Nat_Lip_C_4_AB_M_08_NEG_25Jan18_Brandi-WCSH5801.raw",
5+
"./test_data/test_lipid_data/Blanch_Nat_Lip_C_4_AB_M_08_POS_23Jan18_Brandi-WCSH5801.raw"
66
],
77
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.output_directory": "output",
8-
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.corems_toml_path": "./test_data/test_lcms_metab_data/emsl_lcmetab_corems_params_test.toml",
9-
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.msp_file_path": "./test_data/test_lcms_metab_data/20250407_gnps_curated.msp",
10-
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.scan_translator_path": "./test_data/test_lcms_metab_data/emsl_lcmetab_scan_translator.toml",
8+
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.corems_toml_path": "./configuration/lcms_metab_configs/emsl_lcms_metab_corems_params.toml",
9+
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.msp_file_path": "./test_data/test_lcms_metab_data/database.msp",
10+
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.scan_translator_path": "./configuration/lcms_metab_configs/emsl_lcms_metab_scan_translator.toml",
1111
"lcmsMetabolomics.runMetaMSLCMSMetabolomics.cores": 1
1212
}

0 commit comments

Comments
 (0)