chore/fill value consistency#135
Merged
Merged
Conversation
Contributor
Author
|
@emmanuelmathot do you have the s3 URL for an image with missing values, like the one in https://deploy-preview-17355--ol-site.netlify.app/en/latest/examples/geozarr-stretch.html? I don't have a local example, and I couldn't find the source for that image on s3 |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
emmanuelmathot
left a comment
emmanuelmathot
left a comment
There was a problem hiding this comment.
LGTM. Any swath-truncated granule would work for visual validation, e.g.:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #122 by consistently using NaN as a fill value for float exports. The lower-resolution data were being exported with out-of-range values set to 0.0, which is incorrect. After this PR, they should be set to NaN.