Skip to content

feat: include b08 in resolution groups#152

Merged
d-v-b merged 2 commits intoEOPF-Explorer:mainfrom
d-v-b:feat/include-b08-in-r10m-r20m-r60m
Apr 2, 2026
Merged

feat: include b08 in resolution groups#152
d-v-b merged 2 commits intoEOPF-Explorer:mainfrom
d-v-b:feat/include-b08-in-r10m-r20m-r60m

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented Mar 31, 2026

b08 is not downsampled in the source s2 product. This PR adds lower scale levels for b08 in the native resolution levels.

b08 is not downsampled in the source s2 product. This PR adds lower scale levels for b08 in the native resolution levels.
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/eopf_geozarr/s2_optimization/s2_multiscale.py 88.63% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

fixes a drop in test coverage on this branch, and also fixes a pre-existing bug in
how categorical downsampling worked, due to that code path not being tested
properly.
@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented Mar 31, 2026

closes #79

@d-v-b d-v-b requested a review from emmanuelmathot March 31, 2026 14:57
Copy link
Copy Markdown
Contributor

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested locally

@emmanuelmathot
Copy link
Copy Markdown
Contributor

@d-v-b Good to merge?

@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented Apr 2, 2026

@d-v-b Good to merge?

yes! merging now

@d-v-b d-v-b merged commit c1a1f28 into EOPF-Explorer:main Apr 2, 2026
5 checks passed
@github-actions github-actions bot mentioned this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants