Lightweight Dask metrics#25
Closed
wietzesuijker wants to merge 1 commit into
Closed
Conversation
ef2eecf to
aae0dfb
Compare
8bc1006 to
401c032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic observability to compare runs and debug slowdowns.
What changed
--dask-mode {threads,processes,single-threaded}--dask-workers,--dask-threads-per-worker--dask-perf-html <path>for Dask HTML performance report<output>/debug/(on success and failure)dask_run_summary.json(params + wall time)dask_metrics.jsonand timestampeddask_metrics_<run_id>_attemptN.jsonwall_clock_s,workers,threads_total,tasks_observed,tasks_per_sec,compute_time_s_sum,transfer_time_s_sum,memory_used_bytes,memory_limit_bytes, optionalspilled_nbytes,dashboard_link.Dependencies
ipykernel,jupyter,bokeh(for testing/diagnostics/UI. I should probably ditch .ipynb support, it was useful for testing).Compat
threads, 4×1)Example
Somewhat worryingly, this example took four attempts the last time I tried (it skips data already processed), the last attempt produced this dask_metrics.json
the uv.lock diff is gross, I haven't used uv much, sorry for that.
_*edit:
Deprecated for now, I dropped this earlier "fix", which may actually be more of a feature than a bug, i.e., one should specify the correct groups.
563e1f5
DataTree(skips missing/empty) (563e1f5)_