This repository was archived by the owner on Aug 30, 2022. It is now read-only.
build.sh: switch from CMAKE_FRAMEWORK_PATH to CMAKE_MODULE_PATH#503
Open
pnx wants to merge 1 commit into
Open
Conversation
nksanthosh
requested review from
nksanthosh,
spoonincode and
tbfleming
and removed request for
tbfleming
nksanthosh
suggested changes
Sep 21, 2020
nksanthosh
left a comment
nksanthosh
left a comment
There was a problem hiding this comment.
Can you please use CMAKE_PREFIX_PATH instead and resubmit? Thank you
…_PATH, instead pass them to cmake in CMAKE_PREFIX_PATH CMAKE_FRAMEWORK_PATH is bad as it's read by cmake but it is not available in cmake scripts. Also according to the documentation this variable should contain path to OS X frameworks.
pnx
force-pushed
the
cmake-variables-fix
branch
from
27732f6 to
0a8294c
Compare
Author
Fixed and pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
CMAKE_FRAMEWORK_PATH is bad as it's read by cmake but it is not available in cmake scripts.
Also according to the documentation this variable should contain path to OS X frameworks.
CMAKE_MODULE_PATH is the right way to go.
By adding this code to CMakeLists.txt (line 78 in this case):
And run:
$ export CMAKE_FRAMEWORK_PATH=/usr/opt/eosio.cdt/1.7 $ cmake ..You get the following output:
Deployment Changes
API Changes
Documentation Additions