Skip to content

Added Highs::closeLogFile(), and calling this before returning from the command line executable#2558

Merged
jajhall merged 3 commits into
latestfrom
fix-2534
Oct 5, 2025
Merged

Added Highs::closeLogFile(), and calling this before returning from the command line executable#2558
jajhall merged 3 commits into
latestfrom
fix-2534

Conversation

@jajhall
Copy link
Copy Markdown
Member

@jajhall jajhall commented Oct 4, 2025

This ensures that the log file is closed, but surely that happens in the destructor of the Highs class.

Hence I'm puzzled by the issue raised in #2534

Still Highs::closeLogFile() may be useful to someone, and now there's an explicit flush of Highs::options_.log_options.log_stream in the destructor.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.70%. Comparing base (b9cee31) to head (2e5d7eb).
⚠️ Report is 26 commits behind head on latest.

Files with missing lines Patch % Lines
app/RunHighs.cpp 42.10% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2558      +/-   ##
==========================================
+ Coverage   79.66%   79.70%   +0.04%     
==========================================
  Files         346      346              
  Lines       86430    86427       -3     
==========================================
+ Hits        68854    68889      +35     
+ Misses      17576    17538      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@galabovaa galabovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jajhall jajhall merged commit 9591f8a into latest Oct 5, 2025
305 of 308 checks passed
@jajhall jajhall deleted the fix-2534 branch October 5, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants