Skip to content

Fix edge-case assertion failures in presolve and domain propagation code#3149

Open
fwesselm wants to merge 26 commits into
ERGO-Code:latestfrom
fwesselm:fix-3074-2
Open

Fix edge-case assertion failures in presolve and domain propagation code#3149
fwesselm wants to merge 26 commits into
ERGO-Code:latestfrom
fwesselm:fix-3074-2

Conversation

@fwesselm

Copy link
Copy Markdown
Collaborator

This is motivated by #3074:

  1. Use HighsCDouble precision for objective accumulations (avoid summing up doubles).
  2. HighsDomain::resolveLinearGeq and HighsDomain::resolveLinearLeq: Added a guard condition before dropping a bound change from the explanation to verify that the explanation remains valid.

@fwesselm
fwesselm requested a review from Opt-Mucca July 15, 2026 09:21
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.05825% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.01%. Comparing base (8985537) to head (7a2af0f).
⚠️ Report is 78 commits behind head on latest.

Files with missing lines Patch % Lines
highs/mip/HighsDomain.cpp 98.36% 3 Missing ⚠️
highs/mip/HighsMipWorker.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3149      +/-   ##
==========================================
- Coverage   73.19%   73.01%   -0.19%     
==========================================
  Files         430      432       +2     
  Lines      104154   104423     +269     
  Branches    16738    16801      +63     
==========================================
+ Hits        76239    76240       +1     
- Misses      27639    27907     +268     
  Partials      276      276              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the guard alone have been sufficient to fix the bug for the issue?

I'm fine with upgrading a lot of the accumulations to HighsCDouble, but it would be nice to know what price we're paying for this extra level of safety (assuming it's well south of 0.1% and everything's fine)

Edit: Maybe wasn't clear: Happy with the PR! Just want a sanity check we haven't added meaningful overhead (I can try and do this next week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants