Use cnst_ and pbuf_ alternative ic names when reading constituents not in the registry; try no cnst_ names for constituent-dimensioned input fields#438
Open
jimmielin wants to merge 6 commits into
Conversation
…t in the registry
Member
Author
|
fcdba17 is a cherry-pick from ongoing work in UW PBL |
Member
Author
|
Once #439 is merged we could try using this PR and then removing the extra entries in <variable local_name="CH4"
standard_name="CH4"
units="kg kg-1" type="real" constituent="true">
<ic_file_input_names>CH4 cnst_CH4</ic_file_input_names>
</variable>
<variable local_name="CFC12"
standard_name="CFC12"
units="kg kg-1" type="real" constituent="true">
<ic_file_input_names>CFC12 cnst_CFC12</ic_file_input_names>
</variable>
<variable local_name="CFC11"
standard_name="CFC11"
units="kg kg-1" type="real" constituent="true">
<ic_file_input_names>CFC11STAR pbuf_CFC11STAR</ic_file_input_names>
</variable>if it works we could remove the new entries from #439 in this PR as well when this is merged (and passes all the tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
cnst_andpbuf_(prescribed fields from CAM) when reading input files for constituents when they are not in the registry; this is to avoid unnecessary entries in the registry for constituents if the sole purpose is to specifyic_file_input_namesfor them;cam_in_cflx_<name>) from snapshot, try to use the name without thecnst_prefix that SIMA adds, e.g.,cam_in_cflx_num_a4instead of justcam_in_cflx_cnst_num_a4right now.Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: