Skip to content

SIMA patch for energy bug in physics-dynamics coupling#498

Open
jimmielin wants to merge 4 commits into
ESCOMP:developmentfrom
jimmielin:hplin/pdc-energy-bug-fix-sima
Open

SIMA patch for energy bug in physics-dynamics coupling#498
jimmielin wants to merge 4 commits into
ESCOMP:developmentfrom
jimmielin:hplin/pdc-energy-bug-fix-sima

Conversation

@jimmielin
Copy link
Copy Markdown
Member

@jimmielin jimmielin commented May 13, 2026

Tag name (required for release branches):
Originator(s): @jimmielin (adapted from original fixes by @PeterHjortLauritzen)
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What:
How:

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

Describe any changes made to build system:

Describe any changes made to the namelist:

List any changes to the defaults for the input datasets (e.g. boundary datasets):

List all files eliminated and why:

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M       src/data/registry.xml
M       tools/stdnames_to_inputnames_dictionary.xml
  - update long name of cp_or_cv_dycore to clarify its runtime usage
  - add cp_or_cv_dycore_at_start_of_physics_timestep which is used by the dycore energy consistency adjust scheme and energy checker

M       src/dynamics/mpas/dyn_coupling_impl.F90
M       src/dynamics/se/dp_coupling.F90
  - save cp_or_cv_dycore_at_start_of_physics_timestep during d-p coupling

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@jimmielin jimmielin self-assigned this May 13, 2026
@jimmielin jimmielin added the bug-fix This PR was created to fix a specific bug. label May 13, 2026
@jimmielin jimmielin had a problem deploying to CI-tests-on-CIRRUS May 13, 2026 11:05 — with GitHub Actions Failure
@jimmielin jimmielin temporarily deployed to CI-tests-on-CIRRUS May 13, 2026 11:15 — with GitHub Actions Inactive
@jimmielin jimmielin requested review from nusbaume and peverwhee May 13, 2026 16:19
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin!

@nusbaume nusbaume requested a review from kuanchihwang May 13, 2026 17:48
@nusbaume
Copy link
Copy Markdown
Collaborator

@kuanchihwang This PR adds a line to one of the MPAS routines, so I wanted to make you aware. Don't feel like you have to review this whole PR if you don't have the time. Thanks!

Copy link
Copy Markdown
Collaborator

@kuanchihwang kuanchihwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin! I have a couple of (very simple) change requests.

Comment thread src/dynamics/mpas/dyn_coupling_impl.F90 Outdated
Comment thread src/dynamics/mpas/dyn_coupling_impl.F90 Outdated
Co-authored-by: Kuan-Chih Wang <towerman@livemail.tw>
Co-authored-by: Kuan-Chih Wang <towerman@livemail.tw>
@jimmielin jimmielin temporarily deployed to CI-tests-on-CIRRUS May 13, 2026 20:32 — with GitHub Actions Inactive
@jimmielin jimmielin requested a review from kuanchihwang May 13, 2026 20:32
@jimmielin
Copy link
Copy Markdown
Member Author

Thanks @kuanchihwang! Committed your changes as suggested (GitHub auto-resolved the comments)

Copy link
Copy Markdown
Collaborator

@kuanchihwang kuanchihwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @jimmielin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This PR was created to fix a specific bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants